Change blink::WebScreenInfo to content::ScreenInfo

Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5
Cr-Commit-Position: refs/heads/master@{#417058}

[ccameron, 2016-09-07 02:31:16]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

BUG=644545
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ccameron, 2016-09-07 02:38:04]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 02:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 02:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 02:42:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-07 03:26:18]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 03:26:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 03:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 03:36:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ccameron, 2016-09-07 06:14:12]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 06:14:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 06:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 06:27:05]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ccameron, 2016-09-07 18:49:25]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:50:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 19:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:02:55]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-07 19:08:00]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than in
blink. Particularly objectionable that all of the RenderWidget::Create functions
take this blink structure, rather than a content structure.

After this patch, content traffics (almost) exclusively in a content::ScreenInfo
type, which is converted to a blink::WebScreenInfo only inside the renderer
process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information in
blink (there is no "real" ICC profile structure in Blink, and to the extent that
it
does exist, it will be removed).

BUG=644545
==========

[ccameron, 2016-09-07 19:08:00]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2016-09-07 19:08:25]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than in
blink. Particularly objectionable that all of the RenderWidget::Create functions
take this blink structure, rather than a content structure.

After this patch, content traffics (almost) exclusively in a content::ScreenInfo
type, which is converted to a blink::WebScreenInfo only inside the renderer
process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information in
blink (there is no "real" ICC profile structure in Blink, and to the extent that
it
does exist, it will be removed).

BUG=644545
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than in
blink. Particularly objectionable that all of the RenderWidget::Create
functions take this blink structure, rather than a content structure.

After this patch, content traffics (almost) exclusively in a content::ScreenInfo
type, which is converted to a blink::WebScreenInfo only inside the renderer
process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information in
blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
==========

[ccameron, 2016-09-07 19:09:21]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than in
blink. Particularly objectionable that all of the RenderWidget::Create
functions take this blink structure, rather than a content structure.

After this patch, content traffics (almost) exclusively in a content::ScreenInfo
type, which is converted to a blink::WebScreenInfo only inside the renderer
process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information in
blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
==========

[ccameron, 2016-09-07 19:12:04]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ccameron, 2016-09-07 19:12:11]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-07 19:31:28]

Patchset #5 (id:80001) has been deleted

[ccameron, 2016-09-07 19:31:38]

Patchset #4 (id:60001) has been deleted

[ccameron, 2016-09-07 19:31:47]

Patchset #3 (id:40001) has been deleted

[ccameron, 2016-09-07 19:32:02]

Patchset #2 (id:20001) has been deleted

[ccameron, 2016-09-07 19:32:15]

Patchset #1 (id:1) has been deleted

[ccameron, 2016-09-07 19:41:06]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ccameron, 2016-09-07 19:43:40]

ccameron@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org, dtrainor@chromium.org,
estade@chromium.org
- hubbe@chromium.org

[ccameron, 2016-09-07 19:43:41]

PTAL -- a big rename in content and some related places.

dtrainor: please do blimp/
estade: please do components/autofill/
avi: place do content/
dcheng: please do _messages*

[dcheng, 2016-09-07 19:52:29]

https://codereview.chromium.org/2317563004/diff/120001/content/common/view_me...
File content/common/view_messages.h (right):

https://codereview.chromium.org/2317563004/diff/120001/content/common/view_me...
content/common/view_messages.h:90:
blink::WebScreenOrientationLandscapeSecondary)
Is it possible to remove this now?

[ccameron, 2016-09-07 19:52:39]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:53:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-09-07 19:54:07]

autofill lgtm

"""
When to use To Be Reviewed (TBR)

- For widespread or refactoring changes that are mechanical or global in nature,
it is acceptable to TBR the OWNERS required for submission, as long as your
changes have had the appropriate level of review or general approval.  (For
example, if touching hundreds of files across the codebase, a thread on the
chromium-dev mailing list may be better than getting individual approval from
dozens of different OWNERS.)
"""

[1] http://dev.chromium.org/developers/owners-files

[ccameron, 2016-09-07 20:11:18]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:11:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-09-07 20:12:11]

lgtm

stampity stamp

[ccameron, 2016-09-07 20:19:52]

Patchset #3 (id:140001) has been deleted

[ccameron, 2016-09-07 20:21:30]

https://codereview.chromium.org/2317563004/diff/120001/content/common/view_me...
File content/common/view_messages.h (right):

https://codereview.chromium.org/2317563004/diff/120001/content/common/view_me...
content/common/view_messages.h:90:
blink::WebScreenOrientationLandscapeSecondary)
On 2016/09/07 19:52:29, dcheng wrote:
> Is it possible to remove this now?

It's still in use by blink::WebDeviceEmulationParams, which IMO should undergo a
similar treatment (but that's probably better for a separate patch).

[commit-bot: I haz the power, 2016-09-07 20:25:27]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dcheng, 2016-09-07 20:42:48]

ipc lgtm

[commit-bot: I haz the power, 2016-09-07 21:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:18:44]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-09-07 21:34:22]

Thanks all!

Adding TBR for blimp/, based on Evan's remarks.

[ccameron, 2016-09-07 21:37:19]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ccameron, 2016-09-07 21:40:06]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:40:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:49:54]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-09-07 21:49:57]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-09-07 21:52:51]

Description was changed from

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change blink::WebScreenInfo to content::ScreenInfo

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5
Cr-Commit-Position: refs/heads/master@{#417058}
==========

[commit-bot: I haz the power, 2016-09-07 21:52:54]

Patchset 2 (id:??) landed as
https://crrev.com/2f4515313ffa7f28fa241c098d6e2ba0a5b4ccf5
Cr-Commit-Position: refs/heads/master@{#417058}