Issue 231743006: Run Dart closures invoked from JS in the correct Zone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231743006: Run Dart closures invoked from JS in the correct Zone

Created:
6 years, 8 months ago by justinfagnani

Modified:
6 years, 8 months ago

Reviewers:
Chris Bracken, Jacob

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/1847

Visibility:
Public.

More Reviews

Description

Run Dart closures invoked from JS in the correct Zone BUG=https://code.google.com/p/dart/issues/detail?id=17301

Patch Set 1 #

Patch Set 2 : DO NOT SUBMIT: Non-working fix for round-trip functions #

Total comments: 2

Patch Set 3 : Don't work!: Add function-specific proxy caching #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -17 lines)			Patch
	M	Source/bindings/dart/DartJsInterop.cpp	View	1 2	3 chunks	+30 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

justinfagnani

This CL depends on https://codereview.chromium.org/222203009 which wraps functions in the correct Zone in Dart. Since ...

6 years, 8 months ago (2014-04-10 00:26:44 UTC) #1

justinfagnani

On 2014/04/10 00:49:51, Jacob wrote: > lgtm I tried to fix the round trip problem, ...

6 years, 8 months ago (2014-04-10 03:57:34 UTC) #4

Jacob

6 years, 8 months ago (2014-04-16 22:27:55 UTC) #5

lgtm. a couple minor comments.

https://codereview.chromium.org/231743006/diff/20001/Source/bindings/dart/Dar...
File Source/bindings/dart/DartJsInterop.cpp (right):

https://codereview.chromium.org/231743006/diff/20001/Source/bindings/dart/Dar...
Source/bindings/dart/DartJsInterop.cpp:100: Dart_ListSetAt(dartFunctionArgs, i +
offset, JsInterop::toDart(argsList->Get(i)));
nit: keep the style consistent and replace
i + offset with
offset++

https://codereview.chromium.org/231743006/diff/20001/Source/bindings/dart/Dar...
Source/bindings/dart/DartJsInterop.cpp:223: if
(DartUtilities::isFunction(domData, handle)) {
add a TODO to remove this isFunction check and switch to two native methods one
that takes functions and one that takes all other objects.

Expand Messages | Collapse Messages