Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 231743002: Fix constructor initializer space conventions (dartbug.com/17642). (Closed)

Created:
6 years, 8 months ago by pquitslund
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix constructor initializer space conventions (dartbug.com/17642). R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=34893

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
6 years, 8 months ago (2014-04-09 20:11:29 UTC) #1
scheglov
LGTM
6 years, 8 months ago (2014-04-09 20:17:37 UTC) #2
pquitslund
Committed patchset #2 manually as r34893 (presubmit successful).
6 years, 8 months ago (2014-04-09 20:25:40 UTC) #3
Brian Wilkerson
6 years, 8 months ago (2014-04-10 22:12:18 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698