Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2317353003: [deoptimizer] Support materialization of ContextExtension. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Support materialization of ContextExtension. This adds support to the deoptimizer to materialize ContextExtension objects that have been de-materialized by escape analysis. This is follow-up to the inline allocation of such objects during the create lowering phase (i.e. JSCreateWithContext and JSCreateCatchContext). R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-644245 BUG=chromium:644245 Committed: https://crrev.com/9984d6f689eb722363efa86f34522f2dc5e3bbc5 Cr-Commit-Position: refs/heads/master@{#39270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M src/deoptimizer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-644245.js View 1 chunk +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-08 08:38:14 UTC) #2
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-08 08:51:15 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-08 09:24:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317353003/1
4 years, 3 months ago (2016-09-08 10:31:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 10:33:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 10:33:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9984d6f689eb722363efa86f34522f2dc5e3bbc5
Cr-Commit-Position: refs/heads/master@{#39270}

Powered by Google App Engine
This is Rietveld 408576698