Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

Issue 2317343006: Fix console viewport test failures with scroll anchoring. (Closed)
Patch Set: Add comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
index 2d7a9f52cbe51534aa0c1ffc6ca005de7db5c21e..ce80f8e579fb50c5987b9c04adbe7ed7d158d7c1 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
@@ -88,13 +88,13 @@ function test()
function testViewportMutationsShouldPreserveStickToBottom(next)
{
- viewport._contentElement.children[1].innerText = "More than 2 lines: foo\n\nbar";
+ viewport._contentElement.lastChild.innerText = "More than 2 lines: foo\n\nbar";
lushnikov 2016/09/12 20:18:39 how does scroll anchoring picks a node to anchor?
skobes 2016/09/12 20:22:37 Roughly, it will pick the first visible element.
lushnikov 2016/09/13 00:09:21 I still don't understand how the change helps to m
luoe 2016/09/13 01:30:38 skobes@, on second thought, I'm a bit uncertain, t
skobes 2016/09/13 20:25:04 What I observe is that when we set innerText for t
skobes 2016/09/13 20:25:04 SANACLAP doesn't trigger because no CSS properties
dumpAndContinue(onMessagesDumped);
function onMessagesDumped()
{
viewport.setStickToBottom(false);
- viewport._contentElement.children[1].innerText = "More than 3 lines: foo\n\n\nbar";
+ viewport._contentElement.lastChild.innerText = "More than 3 lines: foo\n\n\nbar";
dumpAndContinue(next);
}
},
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698