third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2317343006: Fix console viewport test failures with scroll anchoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2317343006: Fix console viewport test failures with scroll anchoring. (Closed)

Patch Set: Add comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html ('K') | « third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index d756b77903792d13bb761f5cd8286afeac49b991..f013d2f57ff2fdc95fbdb151636b3a005824e927 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -118,7 +118,9 @@ WebInspector.ConsoleViewMessage.prototype = {

{

if (this._cachedHeight)

return this._cachedHeight;

- const defaultConsoleRowHeight = 18; // Sync with consoleView.css

+ // This value reflects the 18px min-height of .console-message, plus the

+ // 1px border of .console-message-wrapper. Keep in sync with consoleView.css.

+ const defaultConsoleRowHeight = 19;

if (this._message.type === WebInspector.ConsoleMessage.MessageType.Table) {

var table = this._message.parameters[0];

if (table && table.preview)