Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 231733004: Merge 260031 "Fix infinite recursion on hiding panel when create..." (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
Reviewers:
flackr
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Merge 260031 "Fix infinite recursion on hiding panel when create..." > Fix infinite recursion on hiding panel when created during fullscreen mode. > > BUG=355989 > TEST=Ensure hangouts is running, enter fullscreen and receive a message. There should be no crash and panel should show after exiting fullscreen. > R=oshima@chromium.org > > Review URL: https://codereview.chromium.org/215253003 TBR=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M ash/wm/default_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 3 chunks +0 lines, -6 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
6 years, 8 months ago (2014-04-09 22:33:07 UTC) #1
oshima
Committed patchset #1 manually as r262843.
6 years, 8 months ago (2014-04-09 22:33:18 UTC) #2
flackr
6 years, 8 months ago (2014-04-09 23:48:44 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698