Issue 215253003: Fix infinite recursion on hiding panel when created during fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215253003: Fix infinite recursion on hiding panel when created during fullscreen mode. (Closed)

Created:
6 years, 9 months ago by flackr

Modified:
6 years, 9 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix infinite recursion on hiding panel when created during fullscreen mode. BUG=355989 TEST=Ensure hangouts is running, enter fullscreen and receive a message. There should be no crash and panel should show after exiting fullscreen. R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260031

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -15 lines)			Patch
M	ash/wm/default_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/panels/panel_layout_manager.h	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	ash/wm/panels/panel_layout_manager.cc	View	4 chunks	+2 lines, -8 lines	0 comments	Download

Total messages: 6 (0 generated)

oshima

lgtm thanks, I confirmed that this fixes the problem and panels are still working as ...

6 years, 9 months ago (2014-03-27 21:14:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/215253003/1

6 years, 9 months ago (2014-03-27 21:22:11 UTC) #4

flackr

6 years, 9 months ago (2014-03-27 23:57:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r260031 (presubmit successful).