Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2317263002:
Benchmarks for testing GrResourceCache replacement policy when over budget. (Closed)
|
Created:
4 years, 3 months ago by bsalomon Modified:
4 years, 3 months ago Reviewers:
robertphillips CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionBenchmarks for testing changes to GrResourceCache replacement policy when over budget.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002
Committed: https://skia.googlesource.com/skia/+/b3cb2142725f9d0cd88a7200770536bc21f73b14
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : rebase? #Patch Set 4 : add comment #Patch Set 5 : better #Patch Set 6 : comments #Patch Set 7 : comment update #
Total comments: 10
Patch Set 8 : Address comments #Patch Set 9 : fix class name #Patch Set 10 : fix no return warning #Patch Set 11 : fix uninit warning #Messages
Total messages: 26 (15 generated)
Description was changed from ========== Benchmarks for testing GrResourceCache replacement policy when over budget. ========== to ========== Benchmarks for testing GrResourceCache replacement policy when over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 ==========
Description was changed from ========== Benchmarks for testing GrResourceCache replacement policy when over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 ========== to ========== Benchmarks for testing changes to GrResourceCache replacement policy when over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 ==========
bsalomon@google.com changed reviewers: + robertphillips@google.com
lgtm https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... File bench/ImageCacheBudgetBench.cpp (right): https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:87: void onPerCanvasPreDraw(SkCanvas* canvas) override { extra space here after '=' ? https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:119: void onDraw(int loops, SkCanvas* canvas) override { pre++ to match everyone else ? https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:173: */ ImageCacheBudgetDynamicBench ? https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:176: enum class Mode { an -> and ? https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:241: private: comment wrong ?
https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... File bench/ImageCacheBudgetBench.cpp (right): https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:87: void onPerCanvasPreDraw(SkCanvas* canvas) override { On 2016/09/08 16:55:48, robertphillips wrote: > extra space here after '=' ? Done. https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:119: void onDraw(int loops, SkCanvas* canvas) override { On 2016/09/08 16:55:48, robertphillips wrote: > pre++ to match everyone else ? Done. https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:173: */ On 2016/09/08 16:55:48, robertphillips wrote: > ImageCacheBudgetDynamicBench ? Done. https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:176: enum class Mode { On 2016/09/08 16:55:48, robertphillips wrote: > an -> and ? Done. https://codereview.chromium.org/2317263002/diff/120001/bench/ImageCacheBudget... bench/ImageCacheBudgetBench.cpp:241: private: On 2016/09/08 16:55:48, robertphillips wrote: > comment wrong ? Done.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2317263002/#ps140001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2317263002/#ps160001 (title: "fix class name")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2317263002/#ps180001 (title: "fix no return warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2317263002/#ps60002 (title: "fix uninit warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Benchmarks for testing changes to GrResourceCache replacement policy when over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 ========== to ========== Benchmarks for testing changes to GrResourceCache replacement policy when over budget. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2317263002 Committed: https://skia.googlesource.com/skia/+/b3cb2142725f9d0cd88a7200770536bc21f73b14 ==========
Message was sent while issue was closed.
Committed patchset #11 (id:60002) as https://skia.googlesource.com/skia/+/b3cb2142725f9d0cd88a7200770536bc21f73b14 |
