Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 231723005: Fix logic surrounding window / root window coordinates in Ash. (Closed)

Created:
6 years, 8 months ago by zturner
Modified:
6 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Fix logic surrounding window / root window coordinates in Ash. This was causing, among potentially other side effects, javascript functions window.screenX and window.screenY to always return (0,0) in Windows Ash. BUG=318614 TESTS= 1) Verified correct behavior of window.screenX and window.screenY in both desktop and ash, in regular / maximized state. 2) Verified correct behavior of fullscreen flash / HTML5 video. 3) Verified no issues arise on Win7 classic mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +5 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zturner
6 years, 8 months ago (2014-04-10 16:37:49 UTC) #1
zturner
Been continuing to try to break this, and everything appears to work. My test matrix ...
6 years, 8 months ago (2014-04-11 01:05:47 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-15 17:44:32 UTC) #3
zturner
The CQ bit was checked by zturner@chromium.org
6 years, 8 months ago (2014-04-15 17:45:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/231723005/1
6 years, 8 months ago (2014-04-15 17:46:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/231723005/1
6 years, 8 months ago (2014-04-16 01:21:08 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 02:35:27 UTC) #7
Message was sent while issue was closed.
Change committed as 264072

Powered by Google App Engine
This is Rietveld 408576698