Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 231723004: Revert 171187 "Disable x-webkit-speech" (Closed)

Created:
6 years, 8 months ago by jianli
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, Paweł Hajdan Jr., Sergey Berezin
Visibility:
Public.

Description

Revert 171187 "Disable x-webkit-speech" http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/24055 http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35844 > Disable x-webkit-speech > > This does not remove the code yet, only makes x-webkit-speech > test-only (only exposed during LayoutTests) which makes > this patch only a one-line change. We should follow up this > change with a full removal of this feature including > all tests. > > x-webkit-speech is a Chrome-only feature which was > announced as deprecated Feb 2014: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jlPdpx6jErE > Current usage is at about 0.487% of reported Chrome page views > which is (well) above our normal 0.06% removal threshold: > http://www.chromestatus.com/metrics/feature/popularity#PrefixedSpeechAttribute > > However, hours ago we recieved report of cases where *requiring > user interaction* speech can be captured for up to 8 seconds > or until the user stops un-interrupted speaking without proper > appearance of the "Allow this site to use your microphone" > infobar. > > Although this is only a medium-security issue (requires > user interaction and very limited duration), this is still > severe enough that we no longer believe we can support > this deprecated, webkit-only feature. > > Removing this feature will not affect mobile users > which already have access to speech-input via various > speech-enabled keyboards on Android. Desktop sites which > were using this feature can use the modern Web Speech APIs > instead, which are standardized and supported accross many > browsers: http://caniuse.com/web-speech > > Without this feature pages will continue to work, they just > will not be able to get speech input via <input> controls > via these APIs and will either have to use the standard > Web Speech APIs or depend on the operating system to expose > speech input via other methods. > > I've verified that disabling this does not affect the new > JS Web Speech API by testing with: > https://www.google.com/intl/en/chrome/demos/speech.html > > BUG=360448 > > Review URL: https://codereview.chromium.org/231323003 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
6 years, 8 months ago (2014-04-10 00:08:06 UTC) #1
jianli
Committed patchset #1 manually as r171204.
6 years, 8 months ago (2014-04-10 00:08:18 UTC) #2
eseidel
This is not cool. This should have been covered by the Blink CQ. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35844
6 years, 8 months ago (2014-04-10 00:15:46 UTC) #3
eseidel
Note: the original patch is green on all of the bubbles: https://codereview.chromium.org/231323003
6 years, 8 months ago (2014-04-10 00:18:14 UTC) #4
eseidel
6 years, 8 months ago (2014-04-10 00:35:45 UTC) #5
Message was sent while issue was closed.
I now understand that browser_tests/content_browser_tests are not covered by the
Blink CQ.  We need to fix that.  crbug.com/361891

Powered by Google App Engine
This is Rietveld 408576698