Issue 23172013: Third (and hopefully final) change to support bleed flag in Ganesh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23172013: Third (and hopefully final) change to support bleed flag in Ganesh (Closed)

Created:
7 years, 4 months ago by robertphillips

Modified:
7 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL updates the drawBitmap with a mask filter path to respect the bleed flag (and updates the GM)

Patch Set 2 : Fixed comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -31 lines)			Patch
	M	gm/bleed.cpp	View		5 chunks	+27 lines, -1 line	0 comments	Download
	M	src/gpu/SkGpuDevice.cpp	View	1	4 chunks	+39 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/23172013/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/23172013/diff/1/src/gpu/SkGpuDevice.cpp#newcode1091 src/gpu/SkGpuDevice.cpp:1091: // of 'iRect' despite the possible outsets/clamps. despite ...

7 years, 4 months ago (2013-08-20 16:40:55 UTC) #2

robertphillips

7 years, 4 months ago (2013-08-20 16:51:39 UTC) #3

Message was sent while issue was closed.

commited as r10826

https://codereview.chromium.org/23172013/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/23172013/diff/1/src/gpu/SkGpuDevice.cpp#newco...
src/gpu/SkGpuDevice.cpp:1091: // of 'iRect' despite the possible outsets/clamps.
On 2013/08/20 16:40:55, bsalomon wrote:
> despite the -> for all ?

Done.

Expand Messages | Collapse Messages

Issue 23172013: Third (and hopefully final) change to support bleed flag in Ganesh (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed comment #

Messages