Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/clang/scripts/update.py

Issue 2317123004: Roll clang 280106:280836. (Closed)
Patch Set: linux Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index 9787537e70c7e21542e89de12959082fb970f5c6..05f8cde3e2dc94f4813679accae1e4db71d3156f 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -27,7 +27,7 @@ import zipfile
# Do NOT CHANGE this if you don't know what you're doing -- see
# https://chromium.googlesource.com/chromium/src/+/master/docs/updating_clang.md
# Reverting problematic clang rolls is safe, though.
-CLANG_REVISION = '280106'
+CLANG_REVISION = '280836'
use_head_revision = 'LLVM_FORCE_HEAD_REVISION' in os.environ
if use_head_revision:
@@ -333,7 +333,7 @@ def AddGnuWinToPath():
return
gnuwin_dir = os.path.join(LLVM_BUILD_TOOLS_DIR, 'gnuwin')
- GNUWIN_VERSION = '4'
+ GNUWIN_VERSION = '5'
GNUWIN_STAMP = os.path.join(gnuwin_dir, 'stamp')
if ReadStampFile(GNUWIN_STAMP) == GNUWIN_VERSION:
print 'GNU Win tools already up to date.'
@@ -754,21 +754,20 @@ def UpdateClang(args):
if args.with_android:
make_toolchain = os.path.join(
- ANDROID_NDK_DIR, 'build', 'tools', 'make-standalone-toolchain.sh')
+ ANDROID_NDK_DIR, 'build', 'tools', 'make_standalone_toolchain.py')
for target_arch in ['aarch64', 'arm', 'i686']:
# Make standalone Android toolchain for target_arch.
toolchain_dir = os.path.join(
LLVM_BUILD_DIR, 'android-toolchain-' + target_arch)
RunCommand([
make_toolchain,
- '--platform=android-' + ('21' if target_arch == 'aarch64' else '19'),
- '--install-dir="%s"' % toolchain_dir,
Nico 2016/09/08 19:57:08 python script has better quoting, "" no longer nee
- '--system=linux-x86_64',
+ '--api=' + ('21' if target_arch == 'aarch64' else '19'),
+ '--install-dir=%s' % toolchain_dir,
'--stl=stlport',
- '--toolchain=' + {
- 'aarch64': 'aarch64-linux-android-4.9',
- 'arm': 'arm-linux-androideabi-4.9',
- 'i686': 'x86-4.9',
+ '--arch=' + {
+ 'aarch64': 'arm64',
+ 'arm': 'arm',
+ 'i686': 'x86',
}[target_arch]])
# Android NDK r9d copies a broken unwind.h into the toolchain, see
# http://crbug.com/357890
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698