Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: tools/gn/function_write_file_unittest.cc

Issue 2317123003: misc files R-U: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Just rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils_unittest.cc ('k') | ui/app_list/search/history_data_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_write_file_unittest.cc
diff --git a/tools/gn/function_write_file_unittest.cc b/tools/gn/function_write_file_unittest.cc
index 50a0f43ec0ba807da45effb1d56ce6d1dfef9dda..8f2b42a5004f81eb80d3bda9eb04ea0f759676f2 100644
--- a/tools/gn/function_write_file_unittest.cc
+++ b/tools/gn/function_write_file_unittest.cc
@@ -40,7 +40,7 @@ TEST(WriteFile, WithData) {
// Make a real directory for writing the files.
base::ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
- setup.build_settings()->SetRootPath(temp_dir.path());
+ setup.build_settings()->SetRootPath(temp_dir.GetPath());
setup.build_settings()->SetBuildDir(SourceDir("//out/"));
Value some_string(nullptr, "some string contents");
@@ -52,8 +52,9 @@ TEST(WriteFile, WithData) {
// Should be able to write to a new dir inside the out dir.
EXPECT_TRUE(CallWriteFile(setup.scope(), "//out/foo.txt", some_string));
- base::FilePath foo_name = temp_dir.path().Append(FILE_PATH_LITERAL("out"))
- .Append(FILE_PATH_LITERAL("foo.txt"));
+ base::FilePath foo_name = temp_dir.GetPath()
+ .Append(FILE_PATH_LITERAL("out"))
+ .Append(FILE_PATH_LITERAL("foo.txt"));
std::string result_contents;
EXPECT_TRUE(base::ReadFileToString(foo_name, &result_contents));
EXPECT_EQ(some_string.string_value(), result_contents);
« no previous file with comments | « tools/gn/filesystem_utils_unittest.cc ('k') | ui/app_list/search/history_data_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698