Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2317103002: macviews: use platform colors for menus (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: use platform colors for menus Even when in Harmony mode, menus use the platform menu colors. BUG=644555 Committed: https://crrev.com/7c0347a058842e39f7b044793b7b688332a323bc Cr-Commit-Position: refs/heads/master@{#416973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M ui/native_theme/native_theme_mac.mm View 2 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
estade: ptal? :) I think you suggested this earlier, but in the absence of any ...
4 years, 3 months ago (2016-09-07 13:31:51 UTC) #3
Evan Stade
lgtm
4 years, 3 months ago (2016-09-07 15:50:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317103002/1
4 years, 3 months ago (2016-09-07 16:18:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 17:10:20 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:13:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c0347a058842e39f7b044793b7b688332a323bc
Cr-Commit-Position: refs/heads/master@{#416973}

Powered by Google App Engine
This is Rietveld 408576698