Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ui/native_theme/native_theme_mac.mm

Issue 2317103002: macviews: use platform colors for menus (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/native_theme/native_theme_mac.mm
diff --git a/ui/native_theme/native_theme_mac.mm b/ui/native_theme/native_theme_mac.mm
index 87bf24e608e144276b010d5ab5699b8efc2b6a21..ad847bac2369423bfd13174c862ca89db31ba5eb 100644
--- a/ui/native_theme/native_theme_mac.mm
+++ b/ui/native_theme/native_theme_mac.mm
@@ -126,6 +126,29 @@ SkColor ColorToGrayscale(SkColor color) {
}
SkColor NativeThemeMac::GetSystemColor(ColorId color_id) const {
+ // Even with --secondary-ui-md, menus use the platform colors and styling.
+ switch (color_id) {
+ case kColorId_EnabledMenuItemForegroundColor:
+ return NSSystemColorToSkColor([NSColor controlTextColor]);
+ case kColorId_DisabledMenuItemForegroundColor:
+ case kColorId_DisabledEmphasizedMenuItemForegroundColor:
+ return NSSystemColorToSkColor([NSColor disabledControlTextColor]);
+ case kColorId_SelectedMenuItemForegroundColor:
+ return NSSystemColorToSkColor([NSColor selectedMenuItemTextColor]);
+ case kColorId_FocusedMenuItemBackgroundColor:
+ case kColorId_HoverMenuItemBackgroundColor:
+ return NSSystemColorToSkColor([NSColor selectedMenuItemColor]);
+ case kColorId_MenuBackgroundColor:
+ return kMenuPopupBackgroundColor;
+ case kColorId_MenuSeparatorColor:
+ return base::mac::IsOS10_9() ? kMenuSeparatorColorMavericks
+ : kMenuSeparatorColor;
+ case kColorId_MenuBorderColor:
+ return kMenuBorderColor;
+ default:
+ break;
+ }
+
if (ui::MaterialDesignController::IsSecondaryUiMaterial())
return ApplySystemControlTint(GetAuraColor(color_id, this));
@@ -168,25 +191,6 @@ SkColor ColorToGrayscale(SkColor color) {
case kColorId_ButtonHoverColor:
return NSSystemColorToSkColor([NSColor selectedControlTextColor]);
- // Menus.
- case kColorId_EnabledMenuItemForegroundColor:
- return NSSystemColorToSkColor([NSColor controlTextColor]);
- case kColorId_DisabledMenuItemForegroundColor:
- case kColorId_DisabledEmphasizedMenuItemForegroundColor:
- return NSSystemColorToSkColor([NSColor disabledControlTextColor]);
- case kColorId_SelectedMenuItemForegroundColor:
- return NSSystemColorToSkColor([NSColor selectedMenuItemTextColor]);
- case kColorId_FocusedMenuItemBackgroundColor:
- case kColorId_HoverMenuItemBackgroundColor:
- return NSSystemColorToSkColor([NSColor selectedMenuItemColor]);
- case kColorId_MenuBackgroundColor:
- return kMenuPopupBackgroundColor;
- case kColorId_MenuSeparatorColor:
- return base::mac::IsOS10_9() ? kMenuSeparatorColorMavericks
- : kMenuSeparatorColor;
- case kColorId_MenuBorderColor:
- return kMenuBorderColor;
-
// Link.
case kColorId_LinkDisabled:
return SK_ColorBLACK;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698