Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2317043002: [Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch. (Closed)

Created:
4 years, 3 months ago by timvolodine
Modified:
4 years, 3 months ago
Reviewers:
Tobias Sargeant, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch. Merge to M54 (2840) branch. This patch replaces the kEnableAndroidSpellChecker flag with two features "AndroidSpellChecker" and "AndroidSpellCheckerNonLowEnd". This is to allow for finch testing (using chrome experimentation framework) on e.g. canary and dev channels to verify stability and obtain potential crash logs. BUG=583616, 629609 TBR=tobiasjs@chromium.org,torne@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2284583002 Cr-Commit-Position: refs/heads/master@{#415936} (cherry picked from commit 34b1ffd11bd0976a3772c4697f7936e8b01b5601)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -24 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/spellcheck/browser/spellcheck_platform_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/spellcheck/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/spellcheck/common/spellcheck_features.h View 1 chunk +21 lines, -0 lines 0 comments Download
A components/spellcheck/common/spellcheck_features.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M components/spellcheck/common/spellcheck_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/spellcheck/common/spellcheck_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/spellcheck/renderer/spellcheck.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317043002/1
4 years, 3 months ago (2016-09-07 12:50:40 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-07 12:50:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317043002/1
4 years, 3 months ago (2016-09-07 12:53:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 12:55:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698