Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2316743002: Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:… (Closed)

Created:
4 years, 3 months ago by sunnyps
Modified:
4 years, 3 months ago
Reviewers:
Ted C, rkaplow, piman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG=612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG=612596 Review-Url: https://codereview.chromium.org/2184243003 Cr-Commit-Position: refs/heads/master@{#416402} (cherry picked from commit 398642c9f408c394cd87564780b64602e8d310f9) Committed: https://chromium.googlesource.com/chromium/src/+/8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sunnyps
4 years, 3 months ago (2016-09-06 19:02:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d9a5f91b19c30f88e0a9812abf2e936a38dbd0b.

Powered by Google App Engine
This is Rietveld 408576698