Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2184243003: Reland of Default enable main frame before activation and remove finch experiment. (Closed)

Created:
4 years, 4 months ago by sunnyps
Modified:
4 years, 3 months ago
Reviewers:
Ted C, rkaplow, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2170233002/ ) Reason for revert: Relanding after fixing android webview issues Original issue's description: > Revert of Default enable main frame before activation and remove finch experiment. (patchset #1 id:1 of https://codereview.chromium.org/2159103008/ ) > > Reason for revert: > Speculative revert for failing WebView tests on Lollipop: > > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/5794 > https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/4054 > > Both phone and tablet started failing and this is the most "suspicious" change. boliu@ can help investigate further assuming this holds true. > > Original issue's description: > > Default enable main frame before activation and remove finch experiment. > > > > The finch experiment hasn't revealed any regressions other than in page > > load times which has been deemed a blink scheduler issue (see > > crbug.com/614482). > > > > R=piman@chromium.org,rkaplow@chromium.org > > BUG=612596 > > > > Committed: https://crrev.com/45041a7e286c665ab14d8ae0b182e1c11cef65ed > > Cr-Commit-Position: refs/heads/master@{#406916} > > TBR=piman@chromium.org,rkaplow@chromium.org,sunnyps@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=612596 > > Committed: https://crrev.com/2863590ee8e57543f646f4308130765afb02bd44 > Cr-Commit-Position: refs/heads/master@{#407003} TBR=piman@chromium.org,rkaplow@chromium.org,tedchoc@chromium.org BUG=612596 Committed: https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9 Cr-Commit-Position: refs/heads/master@{#416402}

Patch Set 1 #

Patch Set 2 : reparent on top of swap promise fix #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -48 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_features.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -6 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 38 (28 generated)
sunnyps
Created Reland of Default enable main frame before activation and remove finch experiment.
4 years, 4 months ago (2016-07-28 01:56:11 UTC) #1
piman
lgtm
4 years, 4 months ago (2016-07-28 06:06:51 UTC) #13
rkaplow
lgtm
4 years, 4 months ago (2016-07-28 15:27:24 UTC) #14
vmiura
Is this good to go?
4 years, 4 months ago (2016-08-18 17:20:57 UTC) #23
sunnyps
On 2016/08/18 at 17:20:57, vmiura wrote: > Is this good to go? I wanted to ...
4 years, 4 months ago (2016-08-18 17:25:19 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184243003/290001
4 years, 3 months ago (2016-09-02 01:15:32 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/218145) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-02 01:17:48 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184243003/310001
4 years, 3 months ago (2016-09-02 22:04:48 UTC) #35
commit-bot: I haz the power
Committed patchset #8 (id:310001)
4 years, 3 months ago (2016-09-03 00:05:16 UTC) #36
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 00:08:39 UTC) #38
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/398642c9f408c394cd87564780b64602e8d310f9
Cr-Commit-Position: refs/heads/master@{#416402}

Powered by Google App Engine
This is Rietveld 408576698