Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2316733002: gpu: Delete unnecessary code. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, sky, piman
CC:
chromium-reviews, rjkroege, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Delete unnecessary code. gpu::GetNativeGpuMemoryBufferType() never returns SHARED_MEMORY_BUFFER. So there's no reason to have special code that handles this case in IsNativeGpuMemoryBufferFactoryConfigurationSupported() (which is implemented in both content and mus). So delete this code, and update gpu::IsNativeGpuMemoryBufferConfigurationSupported() to check that the native type is never SHARED_MEMORY_BUFFER or EMPTY_BUFFER. BUG=643746 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2b91090ab9e62ebf9d3577d21c286b307a3e45f5 Cr-Commit-Position: refs/heads/master@{#416804}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M gpu/ipc/common/gpu_memory_buffer_support.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/mus_gpu_memory_buffer_manager.cc View 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
sadrul
4 years, 3 months ago (2016-09-06 20:28:54 UTC) #5
piman
lgtm
4 years, 3 months ago (2016-09-06 20:45:27 UTC) #8
sadrul
+tsepez@ for gpu/ipc/common +sky@ for services/ui
4 years, 3 months ago (2016-09-06 22:06:02 UTC) #10
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-06 22:09:20 UTC) #11
sky
LGTM
4 years, 3 months ago (2016-09-06 23:25:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316733002/20001
4 years, 3 months ago (2016-09-07 00:47:56 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 00:52:14 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:53:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b91090ab9e62ebf9d3577d21c286b307a3e45f5
Cr-Commit-Position: refs/heads/master@{#416804}

Powered by Google App Engine
This is Rietveld 408576698