Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 231673006: Add SSL support to the GN build (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add SSL support to the GN build This moves files from the secondary tree to the main one, and renames the "meta" one to //crypto:ssl. It also adds the crypto unit tests. R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263744

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 4

Patch Set 6 : review comments #

Total comments: 1

Patch Set 7 : review comments #2 #

Total comments: 4

Patch Set 8 : fixes for minimal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -416 lines) Patch
M BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -7 lines 0 comments Download
M build/config/crypto.gni View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/linux/pkg_config.gni View 1 2 chunks +8 lines, -0 lines 0 comments Download
A + crypto/BUILD.gn View 1 2 3 4 5 6 7 10 chunks +76 lines, -40 lines 0 comments Download
A net/third_party/nss/ssl/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +138 lines, -0 lines 0 comments Download
D tools/gn/secondary/crypto/BUILD.gn View 1 1 chunk +0 lines, -242 lines 0 comments Download
D tools/gn/secondary/crypto/ssl/BUILD.gn View 1 1 chunk +0 lines, -28 lines 0 comments Download
M tools/gn/secondary/net/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D tools/gn/secondary/net/third_party/nss/BUILD.gn View 1 1 chunk +0 lines, -93 lines 0 comments Download
M tools/gn/secondary/third_party/nss/BUILD.gn View 1 2 3 4 5 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
brettw
https://codereview.chromium.org/231673006/diff/60001/BUILD.gn File BUILD.gn (left): https://codereview.chromium.org/231673006/diff/60001/BUILD.gn#oldcode51 BUILD.gn:51: if (is_posix) { # TODO(brettw) should be use_openssl This ...
6 years, 8 months ago (2014-04-11 21:21:43 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/231673006/diff/80001/crypto/BUILD.gn File crypto/BUILD.gn (right): https://codereview.chromium.org/231673006/diff/80001/crypto/BUILD.gn#newcode246 crypto/BUILD.gn:246: deps += [ ":ssl" ] Why do you do ...
6 years, 8 months ago (2014-04-14 18:38:41 UTC) #2
brettw
PTAL, I think I got everything.
6 years, 8 months ago (2014-04-14 20:23:59 UTC) #3
Ryan Sleevi
Note: //third_party/nss build.gn was not uploaded, because //third_party/nss is managed by DEPS. I'm guessing you ...
6 years, 8 months ago (2014-04-14 20:30:21 UTC) #4
Ryan Sleevi
On 2014/04/14 20:30:21, Ryan Sleevi wrote: > Note: //third_party/nss build.gn was not uploaded, because //third_party/nss ...
6 years, 8 months ago (2014-04-14 20:31:26 UTC) #5
brettw
New snap up
6 years, 8 months ago (2014-04-14 20:41:49 UTC) #6
Ryan Sleevi
LGTM, mod two bits. https://codereview.chromium.org/231673006/diff/120001/crypto/BUILD.gn File crypto/BUILD.gn (right): https://codereview.chromium.org/231673006/diff/120001/crypto/BUILD.gn#newcode182 crypto/BUILD.gn:182: ":platform", crypto_minimal doesn't depend on ...
6 years, 8 months ago (2014-04-14 21:00:59 UTC) #7
brettw
https://codereview.chromium.org/231673006/diff/120001/net/third_party/nss/ssl/BUILD.gn File net/third_party/nss/ssl/BUILD.gn (right): https://codereview.chromium.org/231673006/diff/120001/net/third_party/nss/ssl/BUILD.gn#newcode86 net/third_party/nss/ssl/BUILD.gn:86: include_dirs = [ "bodge" ] On 2014/04/14 21:00:59, Ryan ...
6 years, 8 months ago (2014-04-14 22:41:51 UTC) #8
Ryan Sleevi
On 2014/04/14 22:41:51, brettw wrote: > https://codereview.chromium.org/231673006/diff/120001/net/third_party/nss/ssl/BUILD.gn > File net/third_party/nss/ssl/BUILD.gn (right): > > https://codereview.chromium.org/231673006/diff/120001/net/third_party/nss/ssl/BUILD.gn#newcode86 > ...
6 years, 8 months ago (2014-04-14 22:49:46 UTC) #9
Ryan Sleevi
Patchset 7 LGTM
6 years, 8 months ago (2014-04-14 22:50:56 UTC) #10
brettw
6 years, 8 months ago (2014-04-14 23:25:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #8 manually as r263744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698