Add SSL support to the GN build

crypto/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/crypto.gni")
 
-crypto_minimal_sources = [
-  "hmac.cc",
-  "hmac.h",
-  "hmac_win.cc",
-  "secure_util.cc",
-  "secure_util.h",
-  "symmetric_key.h",
-  "symmetric_key_win.cc",
-  "third_party/nss/chromium-sha256.h",
-  "third_party/nss/sha512.cc",
-]
-
 component("crypto") {
   output_name = "crcrypto"  # Avoid colliding with OpenSSL's libcrypto.
   sources = [
     "apple_keychain.h",
     "apple_keychain_ios.mm",
     "apple_keychain_mac.mm",
     "capi_util.cc",
     "capi_util.h",
     "crypto_export.h",
     "crypto_module_blocking_password_delegate.h",
@@ skipping 62 matching lines @@
     "symmetric_key_openssl.cc",
     "third_party/nss/chromium-blapi.h",
     "third_party/nss/chromium-blapit.h",
     "third_party/nss/chromium-nss.h",
     "third_party/nss/pk11akey.cc",
     "third_party/nss/rsawrapr.c",
     "third_party/nss/secsign.cc",
   ]
 
   deps = [
+    ":crypto_minimal",
+    ":ssl",
     "//base",
     "//base/third_party/dynamic_annotations",
-    "//crypto/ssl:metassl",
   ]
-  forward_dependent_configs_from = [ "//crypto/ssl:metassl" ]
+  forward_dependent_configs_from = [ ":ssl" ]
 
   if (!is_mac && !is_ios) {
     sources -= [
       "apple_keychain.h",
       "mock_apple_keychain.cc",
       "mock_apple_keychain.h",
     ]
   }
 
   if (!is_linux) {
@@ skipping 52 matching lines @@
       "openssl_util.h",
       "rsa_private_key_openssl.cc",
       "secure_hash_openssl.cc",
       "signature_creator_openssl.cc",
       "signature_verifier_openssl.cc",
       "symmetric_key_openssl.cc",
     ]
   }
 
   defines = [ "CRYPTO_IMPLEMENTATION" ]
-
-  # TODO(brettw) once GYP compat is no longer necessary, just move
-  # crypto_minimal_sources to the crypto_minimal target and include a
-  # dependency on it here.
-  sources += crypto_minimal_sources
 }
 
 # A minimal crypto subset for core features that small standalone targets can
 # use to reduce code size.
-static_library("crypto_minimal") {
-  sources = crypto_minimal_sources
+source_set("crypto_minimal") {
+  sources = [
+    "hmac.cc",
+    "hmac.h",
+    "hmac_win.cc",
+    "secure_util.cc",
+    "secure_util.h",
+    "symmetric_key.h",
+    "symmetric_key_win.cc",
+    "third_party/nss/chromium-sha256.h",
+    "third_party/nss/sha512.cc",
+  ]
 
   deps = [
+    ":ssl",
     "//base",
     "//base/third_party/dynamic_annotations",
   ]
 
   defines = [ "CRYPTO_IMPLEMENTATION" ]
 }
 
 test("crypto_unittests") {
   sources = [
     # Tests.
@@ skipping 19 matching lines @@
   ]
 
   if (use_openssl) {
     sources -= [
       "nss_util_unittest.cc",
       "openpgp_symmetric_encryption_unittest.cc",
       "rsa_private_key_nss_unittest.cc",
     ]
   }
 
+  if (use_openssl || !is_linux) {
+    sources -= [
+      "rsa_private_key_nss_unittest.cc",
+      "openpgp_symmetric_encryption_unittest.cc",
+    ]
+  }
+
+  if (use_openssl) {
+    sources -= [ "nss_util_unittest.cc" ]
+  }
+
   deps = [
     ":crypto",
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 
-  if (is_mac) {
-    #deps += "//third_party/nss:nspr"
+  if (is_linux) {
+    deps += [ ":ssl" ]

[Ryan Sleevi, 2014/04/14 18:38:42]

Why do you do this, when :crypto already has the dep?

Alternatively, why isn't this unconditional dep?

+  }
+
+  if (!use_openssl && (is_mac || is_ios || is_win)) {
+    deps += [ "//third_party/nss:nspr" ]

[Ryan Sleevi, 2014/04/14 18:38:42]

Why doesn't the meta :ssl target handle this?

   }
 }
+
+# This is a meta-target that forwards to NSS's SSL library or OpenSSL,
+# according to the state of the crypto flags. A target just wanting to depend
+# on the current SSL library should just depend on this.
+group("ssl") {
+  if (use_openssl) {
+    deps = [ "//third_party/openssl" ]
+  } else {
+    deps = [ "//net/third_party/nss/ssl:libssl" ]

[Ryan Sleevi, 2014/04/14 18:38:42]

//crypto does *not* depend on libssl - it depends on (NSS & NSPR) || (OpenSSL)

A better way to think of this is

meta-target "platform" or "system"

system w/ use_openssl -> openssl
system w/o use_openssl
  !linux -> nss & nspr, hermetic
  Linux -> nspr (pkg-config), nss (pkg-config -ssl), ssl (hermetic)

I expect all other targets (eg: Chromoting, Widevine CDM, etc) to pick up the
dependency on "platform".

The dependency shouldn't be exported as visible symbols into dependents (eg: you
don't depend on crypto/crcrypto to get NSS, you need to depend on
crypto:platform. Likewise, in net/, if you use sockets, you depend on net/ - if
you want to use NSS directly, net AND crypto:platform)

+  }
+}