Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231673005: Move ShortcutInfo, ShortcutLocations from ShellIntegration to web_app. (Closed)

Created:
6 years, 8 months ago by jackhou1
Modified:
6 years, 8 months ago
Reviewers:
benwells, calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Move ShortcutInfo, ShortcutLocations from ShellIntegration to web_app. BUG=356889 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263826

Patch Set 1 #

Patch Set 2 : Linux #

Patch Set 3 : Windws #

Total comments: 10

Patch Set 4 : Sync and rebase #

Patch Set 5 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -214 lines) Patch
M chrome/browser/apps/shortcut_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration.h View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/shell_integration_linux.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 3 4 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 1 6 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/update_shortcut_worker_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.h View 1 2 3 4 10 chunks +74 lines, -14 lines 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 2 3 15 chunks +36 lines, -20 lines 0 comments Download
M chrome/browser/web_applications/web_app_android.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_chromeos.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_linux.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.h View 1 2 3 4 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 3 4 11 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/web_applications/web_app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 2 3 9 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jackhou1
This seems pretty straight forward. My only question is whether web_app is the right place ...
6 years, 8 months ago (2014-04-10 06:44:30 UTC) #1
benwells
Chris - can you look at this first?
6 years, 8 months ago (2014-04-11 23:16:29 UTC) #2
calamity
lgtm w/ nits. https://codereview.chromium.org/231673005/diff/40001/chrome/browser/shell_integration_linux.cc File chrome/browser/shell_integration_linux.cc (left): https://codereview.chromium.org/231673005/diff/40001/chrome/browser/shell_integration_linux.cc#oldcode39 chrome/browser/shell_integration_linux.cc:39: #include "chrome/browser/web_applications/web_app.h" #include "chrome/browser/shell_integration.h" for ShellIntegration::IsFirefoxDefault() ...
6 years, 8 months ago (2014-04-14 04:23:01 UTC) #3
jackhou1
https://codereview.chromium.org/231673005/diff/40001/chrome/browser/shell_integration_linux.cc File chrome/browser/shell_integration_linux.cc (left): https://codereview.chromium.org/231673005/diff/40001/chrome/browser/shell_integration_linux.cc#oldcode39 chrome/browser/shell_integration_linux.cc:39: #include "chrome/browser/web_applications/web_app.h" On 2014/04/14 04:23:01, calamity wrote: > #include ...
6 years, 8 months ago (2014-04-14 05:49:18 UTC) #4
benwells
lgtm Also, someone (jack, chris?) should upload a CL to add calamity, jackhou and tapted ...
6 years, 8 months ago (2014-04-14 06:29:55 UTC) #5
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-14 07:28:31 UTC) #6
jackhou1
The CQ bit was unchecked by jackhou@chromium.org
6 years, 8 months ago (2014-04-14 07:28:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/231673005/80001
6 years, 8 months ago (2014-04-14 07:28:44 UTC) #8
jackhou1
sky, please review for OWNERS: chrome/browser/ chrome/browser/ui/views/
6 years, 8 months ago (2014-04-14 07:30:13 UTC) #9
sky
LGTM
6 years, 8 months ago (2014-04-14 15:23:57 UTC) #10
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-15 01:09:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/231673005/80001
6 years, 8 months ago (2014-04-15 01:11:29 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 02:04:06 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61395
6 years, 8 months ago (2014-04-15 02:04:07 UTC) #14
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 8 months ago (2014-04-15 05:53:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/231673005/80001
6 years, 8 months ago (2014-04-15 05:54:28 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 13:02:18 UTC) #17
Message was sent while issue was closed. 
Change committed as 263826

Powered by Google App Engine
This is Rietveld 408576698