Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/web_applications/web_app_mac.h

Issue 231673005: Move ShortcutInfo, ShortcutLocations from ShellIntegration to web_app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Windws Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_ 5 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
6 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_ 6 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 #include "chrome/browser/shell_integration.h" 14 #include "chrome/browser/shell_integration.h"
calamity 2014/04/14 04:23:01 Can you remove this?
jackhou1 2014/04/14 05:49:19 Done.
15 #include "chrome/browser/web_applications/web_app.h" 15 #include "chrome/browser/web_applications/web_app.h"
16 16
17 namespace web_app { 17 namespace web_app {
18 18
19 // Returns the full path of the .app shim that would be created by 19 // Returns the full path of the .app shim that would be created by
20 // web_app::CreateShortcuts(). 20 // web_app::CreateShortcuts().
21 base::FilePath GetAppInstallPath( 21 base::FilePath GetAppInstallPath(
22 const ShellIntegration::ShortcutInfo& shortcut_info); 22 const web_app::ShortcutInfo& shortcut_info);
23 23
24 // If necessary, launch the shortcut for an app. 24 // If necessary, launch the shortcut for an app.
25 void MaybeLaunchShortcut(const ShellIntegration::ShortcutInfo& shortcut_info); 25 void MaybeLaunchShortcut(const web_app::ShortcutInfo& shortcut_info);
26 26
27 // Creates a shortcut for a web application. The shortcut is a stub app 27 // Creates a shortcut for a web application. The shortcut is a stub app
28 // that simply loads the browser framework and runs the given app. 28 // that simply loads the browser framework and runs the given app.
29 class WebAppShortcutCreator { 29 class WebAppShortcutCreator {
30 public: 30 public:
31 // Creates a new shortcut based on information in |shortcut_info|. 31 // Creates a new shortcut based on information in |shortcut_info|.
32 // A copy of the shortcut is placed in |app_data_dir|. 32 // A copy of the shortcut is placed in |app_data_dir|.
33 // |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle. 33 // |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle.
34 WebAppShortcutCreator( 34 WebAppShortcutCreator(
35 const base::FilePath& app_data_dir, 35 const base::FilePath& app_data_dir,
36 const ShellIntegration::ShortcutInfo& shortcut_info); 36 const web_app::ShortcutInfo& shortcut_info);
37 37
38 virtual ~WebAppShortcutCreator(); 38 virtual ~WebAppShortcutCreator();
39 39
40 // Returns the base name for the shortcut. 40 // Returns the base name for the shortcut.
41 base::FilePath GetShortcutBasename() const; 41 base::FilePath GetShortcutBasename() const;
42 42
43 // Returns a path to the Chrome Apps folder in the relevant applications 43 // Returns a path to the Chrome Apps folder in the relevant applications
44 // folder. E.g. ~/Applications or /Applications. 44 // folder. E.g. ~/Applications or /Applications.
45 virtual base::FilePath GetApplicationsDirname() const; 45 virtual base::FilePath GetApplicationsDirname() const;
46 46
47 // The full path to the app bundle under the relevant Applications folder. 47 // The full path to the app bundle under the relevant Applications folder.
48 base::FilePath GetApplicationsShortcutPath() const; 48 base::FilePath GetApplicationsShortcutPath() const;
49 49
50 // The full path to the app bundle under the profile folder. 50 // The full path to the app bundle under the profile folder.
51 base::FilePath GetInternalShortcutPath() const; 51 base::FilePath GetInternalShortcutPath() const;
52 52
53 bool CreateShortcuts(ShortcutCreationReason creation_reason, 53 bool CreateShortcuts(ShortcutCreationReason creation_reason,
54 ShellIntegration::ShortcutLocations creation_locations); 54 web_app::ShortcutLocations creation_locations);
55 void DeleteShortcuts(); 55 void DeleteShortcuts();
56 bool UpdateShortcuts(); 56 bool UpdateShortcuts();
57 57
58 protected: 58 protected:
59 // Returns a path to an app bundle with the given id. Or an empty path if no 59 // Returns a path to an app bundle with the given id. Or an empty path if no
60 // matching bundle was found. 60 // matching bundle was found.
61 // Protected and virtual so it can be mocked out for testing. 61 // Protected and virtual so it can be mocked out for testing.
62 virtual base::FilePath GetAppBundleById(const std::string& bundle_id) const; 62 virtual base::FilePath GetAppBundleById(const std::string& bundle_id) const;
63 63
64 // Show the bundle we just generated in the Finder. 64 // Show the bundle we just generated in the Finder.
(...skipping 29 matching lines...) Expand all
94 bool UpdatePlist(const base::FilePath& app_path) const; 94 bool UpdatePlist(const base::FilePath& app_path) const;
95 95
96 // Updates the icon for the shortcut. 96 // Updates the icon for the shortcut.
97 bool UpdateIcon(const base::FilePath& app_path) const; 97 bool UpdateIcon(const base::FilePath& app_path) const;
98 98
99 // Path to the data directory for this app. For example: 99 // Path to the data directory for this app. For example:
100 // ~/Library/Application Support/Chromium/Default/Web Applications/_crx_abc/ 100 // ~/Library/Application Support/Chromium/Default/Web Applications/_crx_abc/
101 base::FilePath app_data_dir_; 101 base::FilePath app_data_dir_;
102 102
103 // Information about the app. 103 // Information about the app.
104 ShellIntegration::ShortcutInfo info_; 104 web_app::ShortcutInfo info_;
105 105
106 DISALLOW_COPY_AND_ASSIGN(WebAppShortcutCreator); 106 DISALLOW_COPY_AND_ASSIGN(WebAppShortcutCreator);
107 }; 107 };
108 108
109 } // namespace web_app 109 } // namespace web_app
110 110
111 #endif // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_ 111 #endif // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698