Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2382)

Unified Diff: chrome/browser/permissions/permission_queue_controller.cc

Issue 2316673002: Fix PushManager.subscribe() permission request on Android (Closed)
Patch Set: Also test notifications permission Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_queue_controller.cc
diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc
index 4825cca9d1e9e4cd243ed95a44248941fe7f22b4..31d4b88d1a481fdea25f0fbe4b1f27b24ab179ce 100644
--- a/chrome/browser/permissions/permission_queue_controller.cc
+++ b/chrome/browser/permissions/permission_queue_controller.cc
@@ -131,6 +131,7 @@ void PermissionQueueController::PendingInfobarRequest::CreateInfoBar(
break;
#if defined(ENABLE_NOTIFICATIONS)
case content::PermissionType::NOTIFICATIONS:
+ case content::PermissionType::PUSH_MESSAGING:
infobar_ = NotificationPermissionInfoBarDelegate::Create(
raymes 2016/09/06 23:06:38 This looks ok to merge to me. I think we actually
GetInfoBarService(id_), requesting_frame_, user_gesture_, profile_,
callback);
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698