Feedback dialog visual tweaks

Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3b949a8022d2f4f6f89e6114a52befee39f40c2e
Cr-Commit-Position: refs/heads/master@{#416970}

[Elly Fong-Jones, 2016-09-06 14:00:11]

Description was changed from

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
==========

to

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-09-06 14:04:46]

Description was changed from

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-09-06 14:04:46]

ellyjones@chromium.org changed reviewers:
+ afakhry@chromium.org

[Elly Fong-Jones, 2016-09-06 14:05:24]

ellyjones@chromium.org changed reviewers:
+ dbeam@chromium.org

[Elly Fong-Jones, 2016-09-06 14:05:55]

afakhry: ptal at chrome/browser/resources/feedback change
dbeam: ptal at ui/webui change

thanks :)

[apacible, 2016-09-06 16:00:41]

On 2016/09/06 14:05:55, Elly Jones wrote:
> afakhry: ptal at chrome/browser/resources/feedback change
> dbeam: ptal at ui/webui change
> 
> thanks :)

I think #2 should fix 643082 as well.

[Elly Fong-Jones, 2016-09-06 16:05:01]

On 2016/09/06 16:00:41, apacible wrote:
> On 2016/09/06 14:05:55, Elly Jones wrote:
> > afakhry: ptal at chrome/browser/resources/feedback change
> > dbeam: ptal at ui/webui change
> > 
> > thanks :)
> 
> I think #2 should fix 643082 as well.

Yep! The behavior referred to in #2 is exactly 643082, which I introduced in
https://codereview.chromium.org/2295793002.

[apacible, 2016-09-06 16:07:50]

On 2016/09/06 16:05:01, Elly Jones wrote:
> On 2016/09/06 16:00:41, apacible wrote:
> > On 2016/09/06 14:05:55, Elly Jones wrote:
> > > afakhry: ptal at chrome/browser/resources/feedback change
> > > dbeam: ptal at ui/webui change
> > > 
> > > thanks :)
> > 
> > I think #2 should fix 643082 as well.
> 
> Yep! The behavior referred to in #2 is exactly 643082, which I introduced in
> https://codereview.chromium.org/2295793002.

Thanks :)

[afakhry, 2016-09-06 16:23:26]

lgtm

[Elly Fong-Jones, 2016-09-07 10:37:44]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 10:37:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 11:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 11:44:56]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-07 16:39:42]

lgtm

[Elly Fong-Jones, 2016-09-07 16:58:55]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:59:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:04:39]

Description was changed from

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-07 17:04:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 17:06:29]

Description was changed from

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Feedback dialog visual tweaks

This change:
1) Adds a titlecase variant of IDS_FEEDBACK_REPORT_PAGE_TITLE
2) Changes the feedback dialog to use minWidth/minHeight instead of width/height
3) Gives white-button and blue-button a default font size of 14px

For (2), width/height include the OS window frame; using minWidth/minHeight
seems to look good with both the system frame and the custom frame. Without
this change, the buttons at the bottom-right overlap the privacy notice.

For (3), the MD typography spec gives buttons a text size of 14px; if this
is not done, the buttons end up using the default Cocoa control text size on
Mac, which is something like 10px.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3b949a8022d2f4f6f89e6114a52befee39f40c2e
Cr-Commit-Position: refs/heads/master@{#416970}
==========

[commit-bot: I haz the power, 2016-09-07 17:06:30]

Patchset 1 (id:??) landed as
https://crrev.com/3b949a8022d2f4f6f89e6114a52befee39f40c2e
Cr-Commit-Position: refs/heads/master@{#416970}