feedback UI: use native window controls on Mac

feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fba5c5c1252ddbe65244e1907b436a95b63d24a4
Cr-Commit-Position: refs/heads/master@{#415396}

[Elly Fong-Jones, 2016-08-30 14:19:35]

Description was changed from

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
==========

to

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-08-30 14:19:40]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 14:19:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elly Fong-Jones, 2016-08-30 14:22:38]

Description was changed from

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-08-30 14:22:38]

ellyjones@chromium.org changed reviewers:
+ afakhry@chromium.org

[Elly Fong-Jones, 2016-08-30 14:22:46]

afakhry: ptal? :)

[commit-bot: I haz the power, 2016-08-30 14:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:59:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-08-30 15:05:34]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 15:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:21:41]

Dry run: This issue passed the CQ dry run.

[afakhry, 2016-08-30 16:27:05]

lgtm with nit.
I would also appreciate if you can post a screenshot of the result on mac.

https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/feedback_private.idl (right):

https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/feedback_private.idl:75: boolean
useSystemWindowFrame;
Nit: Please add a comment.

[Elly Fong-Jones, 2016-08-30 17:30:47]

On 2016/08/30 16:27:05, afakhry wrote:
> lgtm with nit.
> I would also appreciate if you can post a screenshot of the result on mac.

If it's okay with you, I will wait until next canary to post one for Mac, since
doing a branded checkout + build on mac takes some hours :(

>
https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
> File chrome/common/extensions/api/feedback_private.idl (right):
> 
>
https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
> chrome/common/extensions/api/feedback_private.idl:75: boolean
> useSystemWindowFrame;
> Nit: Please add a comment.

Done.

[Elly Fong-Jones, 2016-08-30 17:32:32]

ellyjones@chromium.org changed reviewers:
+ rockot@chromium.org

[Elly Fong-Jones, 2016-08-30 17:32:42]

rockot: ptal as //extensions owner? :)

[afakhry, 2016-08-30 17:32:43]

On 2016/08/30 17:30:47, Elly Jones wrote:
> On 2016/08/30 16:27:05, afakhry wrote:
> > lgtm with nit.
> > I would also appreciate if you can post a screenshot of the result on mac.
> 
> If it's okay with you, I will wait until next canary to post one for Mac,
since
> doing a branded checkout + build on mac takes some hours :(
> 

Sounds good.

> >
>
https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
> > File chrome/common/extensions/api/feedback_private.idl (right):
> > 
> >
>
https://codereview.chromium.org/2295793002/diff/20001/chrome/common/extension...
> > chrome/common/extensions/api/feedback_private.idl:75: boolean
> > useSystemWindowFrame;
> > Nit: Please add a comment.
> 
> Done.

[Ken Rockot(use gerrit already), 2016-08-30 17:46:41]

lgtm

[Elly Fong-Jones, 2016-08-30 18:01:57]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-08-30 18:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2295793002/#ps40001
(title: "comment useSystemWindowFrame")

[commit-bot: I haz the power, 2016-08-30 18:02:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:31:38]

Description was changed from

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-30 19:31:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 19:32:55]

Description was changed from

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback UI: use native window controls on Mac

This CL adds a member to FeedbackInfo which instructs the feedback dialog
to use native window controls and implements support for it in the
feedback dialog's JS.

BUG=553991
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fba5c5c1252ddbe65244e1907b436a95b63d24a4
Cr-Commit-Position: refs/heads/master@{#415396}
==========

[commit-bot: I haz the power, 2016-08-30 19:32:56]

Patchset 3 (id:??) landed as
https://crrev.com/fba5c5c1252ddbe65244e1907b436a95b63d24a4
Cr-Commit-Position: refs/heads/master@{#415396}