Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2316593002: Deprecate SVGViewElement.viewTarget attribute (Closed)

Created:
4 years, 3 months ago by Shanmuga Pandi
Modified:
4 years, 3 months ago
Reviewers:
fs, foolip, rwlbuis
CC:
chromium-reviews, krit, rwlbuis, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate SVGViewElement.viewTarget attribute As per SVG2.0, SVGViewElement.viewTarget is removed. https://github.com/w3c/svgwg/commit/c1690ae1b99aa95c648a304ec7a8f7dec46d7c83 Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/X3kyDbj9xlA BUG=633908 Committed: https://crrev.com/b85218655b21bf4a6982336064074fb07a632121 Cr-Commit-Position: refs/heads/master@{#416626}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html View 1 chunk +12 lines, -0 lines 2 comments Download
A third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Shanmuga Pandi
PTAL!! Thanks.
4 years, 3 months ago (2016-09-06 10:24:10 UTC) #3
foolip
lgtm % optional wpt follow-up https://codereview.chromium.org/2316593002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html File third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html (right): https://codereview.chromium.org/2316593002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html#newcode10 third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html:10: view.viewTarget; This works, but ...
4 years, 3 months ago (2016-09-06 10:28:14 UTC) #4
Shanmuga Pandi
https://codereview.chromium.org/2316593002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html File third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html (right): https://codereview.chromium.org/2316593002/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html#newcode10 third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html:10: view.viewTarget; On 2016/09/06 10:28:14, foolip wrote: > This works, ...
4 years, 3 months ago (2016-09-06 11:44:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316593002/1
4 years, 3 months ago (2016-09-06 12:16:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 14:44:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 14:46:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b85218655b21bf4a6982336064074fb07a632121
Cr-Commit-Position: refs/heads/master@{#416626}

Powered by Google App Engine
This is Rietveld 408576698