third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html - Issue 2316593002: Deprecate SVGViewElement.viewTarget attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget.html

Issue 2316593002: Deprecate SVGViewElement.viewTarget attribute (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg>

	5 <view></view>

	6 </svg>

	7 <script>

	8 test(function () {

	9 var view = document.querySelector("view");

	10 view.viewTarget;
	foolip 2016/09/06 10:28:14 This works, but I'd also suggest adding an histori This works, but I'd also suggest adding an historical.html test in https://github.com/w3c/web-platform-tests/tree/master/svg which tests for the absense of this attribute. If you import that test, it should fail and show the deprecation message, and then start passing once it's removed. Adding the other deprecated SVG APIs there would be great as well. Shanmuga Pandi 2016/09/06 11:44:38 Thanks foolip@. Currently I don't have permission Show quoted text On 2016/09/06 10:28:14, foolip wrote: > This works, but I'd also suggest adding an historical.html test in > https://github.com/w3c/web-platform-tests/tree/master/svg which tests for the > absense of this attribute. If you import that test, it should fail and show the > deprecation message, and then start passing once it's removed. Adding the other > deprecated SVG APIs there would be great as well. Thanks foolip@. Currently I don't have permission to upload it to github, I will check internally and will upload the changes.
	11 }, "view.viewTarget should throw deprecation warning");

	12 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/dom/SVGViewElement-viewTarget-expected.txt » ('j') | no next file with comments »