Issue 231653003: Merge 262479 "[Android] Increase the mobile viewport epsilon thr..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 231653003: Merge 262479 "[Android] Increase the mobile viewport epsilon thr..." (Closed)

Created:
6 years, 8 months ago by jdduke (slow)

Modified:
6 years, 8 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1916/src/

Visibility:
Public.

More Reviews

Description

Merge 262479 "[Android] Increase the mobile viewport epsilon thr..." > [Android] Increase the mobile viewport epsilon threshold > > On an N7 V1, the delta between computed content and viewport widths when > width=device-width is ~0.065. Increase the |hasMobileViewport()| query epsilon > when comparing these values to appropriately classify mobile sites. > > BUG=360602 > NOTRY=true > > Review URL: https://codereview.chromium.org/228613006 TBR=jdduke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262817

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r262817.

Expand Messages | Collapse Messages