Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 228613006: [Android] Increase the mobile viewport epsilon threshold (Closed)

Created:
6 years, 8 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Increase the mobile viewport epsilon threshold On an N7 V1, the delta between computed content and viewport widths when width=device-width is ~0.065. Increase the |hasMobileViewport()| query epsilon when comparing these values to appropriately classify mobile sites. BUG=360602 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
aelias@: PTAL... should have tested this on the N7 you gave me before I landed ...
6 years, 8 months ago (2014-04-08 15:54:15 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 8 months ago (2014-04-08 17:33:53 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-08 19:19:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/228613006/1
6 years, 8 months ago (2014-04-08 19:19:51 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 19:41:22 UTC) #5
Message was sent while issue was closed.
Change committed as 262479

Powered by Google App Engine
This is Rietveld 408576698