SkRecordDraw: skip draw ops when the clip is empty

SkRecordDraw: skip draw ops when the clip is empty

   - Adds tests for SkRecordDraw's two main features: cull- and clip- based skipping.
   - Adds full SkCanvas semantic mode to SkRecorder, so it can be used as a target for SkRecordDraw.

BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14124

[f(malita), 2014-04-09 21:44:28]

lgtm + nits

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw.cpp
File src/record/SkRecordDraw.cpp (right):

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:43: CASE(ClipRegion, clipRegion(r.region, r.op));
We could optimize Clip* some: they can be skipped when (fClipEmpty && r.op ==
kIntersect_Op). IOW the executing clip is a no-op when the current clip is
already empty and we're intersecting.

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:56: CASE(PopCull, popCull());
I think popCull should also execute unconditionally, same as restore.

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecorder.cpp
File src/record/SkRecorder.cpp (right):

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecorder.cp...
src/record/SkRecorder.cpp:13: #define INHERITED(method, ...) if (fMode ==
kReadWrite_Mode) this->SkCanvas::method(__VA_ARGS__)
This name will work for now, but I imagine at some point it will clash when
adding an INHERITED typedef in the header.

[mtklein, 2014-04-09 21:52:12]

lgtm

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw.cpp
File src/record/SkRecordDraw.cpp (right):

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:43: CASE(ClipRegion, clipRegion(r.region, r.op));
On 2014/04/09 21:44:28, Florin Malita wrote:
> We could optimize Clip* some: they can be skipped when (fClipEmpty && r.op ==
> kIntersect_Op). IOW the executing clip is a no-op when the current clip is
> already empty and we're intersecting.

Smart.  Will follow up with this.

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecordDraw....
src/record/SkRecordDraw.cpp:56: CASE(PopCull, popCull());
On 2014/04/09 21:44:28, Florin Malita wrote:
> I think popCull should also execute unconditionally, same as restore.

Done.

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecorder.cpp
File src/record/SkRecorder.cpp (right):

https://codereview.chromium.org/231653002/diff/50009/src/record/SkRecorder.cp...
src/record/SkRecorder.cpp:13: #define INHERITED(method, ...) if (fMode ==
kReadWrite_Mode) this->SkCanvas::method(__VA_ARGS__)
On 2014/04/09 21:44:28, Florin Malita wrote:
> This name will work for now, but I imagine at some point it will clash when
> adding an INHERITED typedef in the header.

Yeah, let's handle that when it happens.  I'm using it here for the same purpose
that we normally typedef INHERITED, but with a small amount of extra constraint
on what you can do (i.e. only make void method calls).  I like that extra
constraint until we need to back off.

[commit-bot: I haz the power, 2014-04-09 21:52:19]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/231653002/90001

[commit-bot: I haz the power, 2014-04-09 23:30:42]

Change committed as 14124