Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/debug/live-edit-frame-drop-mode.h

Issue 2316443002: Include only stuff you need, part 8: Fix debug.h -> liveedit.h. (Closed)
Patch Set: ports Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/live-edit-frame-drop-mode.h
diff --git a/src/debug/live-edit-frame-drop-mode.h b/src/debug/live-edit-frame-drop-mode.h
new file mode 100644
index 0000000000000000000000000000000000000000..37becf4218a53a513618f645fda608329ba90bca
--- /dev/null
+++ b/src/debug/live-edit-frame-drop-mode.h
@@ -0,0 +1,28 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef V8_DEBUG_LIVEEDIT_FRAME_DROP_MODE_H_
Michael Starzinger 2016/09/06 08:05:38 nit: Let's call the file "liveedit-frame-drop-mode
marja 2016/09/06 08:24:07 Moved to globals.h
+#define V8_DEBUG_LIVEEDIT_FRAME_DROP_MODE_H_
+
+namespace v8 {
+namespace internal {
+
+// Describes how exactly a frame has been dropped from stack.
+enum LiveEditFrameDropMode {
+ // No frame has been dropped.
+ LIVE_EDIT_FRAMES_UNTOUCHED,
+ // The top JS frame had been calling debug break slot stub. Patch the
+ // address this stub jumps to in the end.
+ LIVE_EDIT_FRAME_DROPPED_IN_DEBUG_SLOT_CALL,
+ // The top JS frame had been calling some C++ function. The return address
+ // gets patched automatically.
+ LIVE_EDIT_FRAME_DROPPED_IN_DIRECT_CALL,
+ LIVE_EDIT_FRAME_DROPPED_IN_RETURN_CALL,
+ LIVE_EDIT_CURRENTLY_SET_MODE
+};
+
+} // namespace internal
+} // namespace v8
+
+#endif // V8_DEBUG_LIVEEDIT_FRAME_DROP_MODE_H_

Powered by Google App Engine
This is Rietveld 408576698