Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ui/views/controls/label.h

Issue 231643002: Added labels under the windows in OverviewMode displaying their current name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added blurred shadows to labels Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/label.h
diff --git a/ui/views/controls/label.h b/ui/views/controls/label.h
index 0964b036c511fd8c15f27d3e96a37213aebd278c..6110f7bbbd1851ebcdb53800a9f8aa0b60887710 100644
--- a/ui/views/controls/label.h
+++ b/ui/views/controls/label.h
@@ -94,6 +94,14 @@ class VIEWS_EXPORT Label : public View {
// Sets the drop shadow's offset from the text.
void SetShadowOffset(int x, int y);
+ // Sets the shadow blur. Default is zero.
tdanderson 2014/04/14 16:58:39 What is the allowable range for shadow_blur_? 0.0
Nina 2014/04/14 17:59:17 It's a bit more complicated. Please see the follow
+ double shadow_blur() const { return shadow_blur_; }
+ void SetShadowBlur(double shadow_blur_);
+
+ // If true, let the shadow surrender the text. Default is false.
tdanderson 2014/04/14 16:58:39 surrender->surround
Nina 2014/04/14 17:59:17 Done.
+ bool mirror_shadow() const { return mirror_shadow_; }
+ void SetMirrorShadow(bool mirror_shadow);
tdanderson 2014/04/14 16:58:39 Since the mutators just have simple one-line imple
Nina 2014/04/14 17:59:17 I'm using the same logic as in SetShadowOffset and
+
// Disables shadows.
void ClearEmbellishing();
@@ -267,6 +275,7 @@ class VIEWS_EXPORT Label : public View {
bool auto_color_readability_;
mutable gfx::Size text_size_;
mutable bool text_size_valid_;
+ double shadow_blur_;
tdanderson 2014/04/14 16:58:39 Add brief comments explaining what shadow_blur_ an
Nina 2014/04/14 17:59:17 Done.
int line_height_;
bool is_multi_line_;
bool is_obscured_;
@@ -291,6 +300,8 @@ class VIEWS_EXPORT Label : public View {
// Should a shadow be drawn behind the text?
bool has_shadow_;
+ bool mirror_shadow_;
+
// The cached heights to avoid recalculation in GetHeightForWidth().
std::vector<gfx::Size> cached_heights_;
int cached_heights_cursor_;

Powered by Google App Engine
This is Rietveld 408576698