Added labels under the windows in OverviewMode displaying their current name.

ui/views/controls/label.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_LABEL_H_
 #define UI_VIEWS_CONTROLS_LABEL_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 76 matching lines @@
   // will force the text color to be readable over it.
   void SetBackgroundColor(SkColor color);
   SkColor background_color() const { return background_color_; }
 
   // Enables a drop shadow underneath the text.
   void SetShadowColors(SkColor enabled_color, SkColor disabled_color);
 
   // Sets the drop shadow's offset from the text.
   void SetShadowOffset(int x, int y);
 
+  // Sets the shadow blur. Default is zero.

[tdanderson, 2014/04/14 16:58:39]

What is the allowable range for shadow_blur_? 0.0 to 1.0?

[Nina, 2014/04/14 17:59:17]

It's a bit more complicated. Please see the following link.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/shadow_valu...

+  double shadow_blur() const { return shadow_blur_; }
+  void SetShadowBlur(double shadow_blur_);
+
+  // If true, let the shadow surrender the text. Default is false.

[tdanderson, 2014/04/14 16:58:39]

surrender->surround

[Nina, 2014/04/14 17:59:17]

Done.

+  bool mirror_shadow() const { return mirror_shadow_; }
+  void SetMirrorShadow(bool mirror_shadow);

[tdanderson, 2014/04/14 16:58:39]

Since the mutators just have simple one-line implementations, I think the
preferred way is to use unix_hacker function naming and to just implement them
here in the header
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...).
I do see many instances where this is not followed, though, so leaving it like
this may be fine.

[Nina, 2014/04/14 17:59:17]

I'm using the same logic as in SetShadowOffset and SetShadowColors… does it make
sense to change it if any of the reviewers have a say in it?

+
   // Disables shadows.
   void ClearEmbellishing();
 
   // Sets horizontal alignment. If the locale is RTL, and the directionality
   // mode is USE_UI_DIRECTIONALITY, the alignment is flipped around.
   //
   // Caveat: for labels originating from a web page, the directionality mode
   // should be reset to AUTO_DETECT_DIRECTIONALITY before the horizontal
   // alignment is set. Otherwise, the label's alignment specified as a parameter
   // will be flipped in RTL locales.
@@ skipping 153 matching lines @@
   SkColor background_color_;
 
   // Set to true once the corresponding setter is invoked.
   bool enabled_color_set_;
   bool disabled_color_set_;
   bool background_color_set_;
 
   bool auto_color_readability_;
   mutable gfx::Size text_size_;
   mutable bool text_size_valid_;
+  double shadow_blur_;

[tdanderson, 2014/04/14 16:58:39]

Add brief comments explaining what shadow_blur_ and mirror_shadow_ represent
(similar to what is done for some of the other members here).

[Nina, 2014/04/14 17:59:17]

Done.

   int line_height_;
   bool is_multi_line_;
   bool is_obscured_;
   bool allow_character_break_;
   ElideBehavior elide_behavior_;
   gfx::HorizontalAlignment horizontal_alignment_;
   base::string16 tooltip_text_;
   // Whether to collapse the label when it's not visible.
   bool collapse_when_hidden_;
   // The following member variable is used to control whether the
   // directionality is auto-detected based on first strong directionality
   // character or is determined by chrome UI's locale.
   DirectionalityMode directionality_mode_;
 
   // Colors for shadow.
   SkColor enabled_shadow_color_;
   SkColor disabled_shadow_color_;
 
   // Space between text and shadow.
   gfx::Point shadow_offset_;
 
   // Should a shadow be drawn behind the text?
   bool has_shadow_;
 
+  bool mirror_shadow_;
+
   // The cached heights to avoid recalculation in GetHeightForWidth().
   std::vector<gfx::Size> cached_heights_;
   int cached_heights_cursor_;
 
   DISALLOW_COPY_AND_ASSIGN(Label);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_LABEL_H_