Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2316423002: Introduce WebRange::isEmpty. (Closed)

Created:
4 years, 3 months ago by dglazkov
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dcheng, dglazkov+blink, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce WebRange::isEmpty. It's more idiomatic in Blink land. R=esprehn BUG= Committed: https://crrev.com/febdb3ec881b4b8503fb3eed429f021803899443 Cr-Commit-Position: refs/heads/master@{#417491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRange.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
esprehn
lgtm
4 years, 3 months ago (2016-09-08 22:34:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316423002/1
4 years, 3 months ago (2016-09-09 01:37:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 03:15:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 03:19:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/febdb3ec881b4b8503fb3eed429f021803899443
Cr-Commit-Position: refs/heads/master@{#417491}

Powered by Google App Engine
This is Rietveld 408576698