third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2316423002: Introduce WebRange::isEmpty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2316423002: Introduce WebRange::isEmpty. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index f2768e08c7501b77daf6b08f034399e2faa6d09e..64d96e082cd58c0c679c10bdaa4abbf5364e3337 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2829,10 +2829,7 @@ void WebViewImpl::didChangeWindowResizerRect()

bool WebViewImpl::getCompositionCharacterBounds(WebVector<WebRect>& bounds)

{

WebRange range = compositionRange();

- if (range.isNull())

- return false;

- if (range.length() == 0)

+ if (range.isEmpty())

return false;

WebLocalFrame* frame = focusedFrame();