third_party/WebKit/Source/core/dom/Element.cpp - Issue 2316303006: Make default spellchecking behavior in html elements configurable via WebSettings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2316303006: Make default spellchecking behavior in html elements configurable via WebSettings. (Closed)

Patch Set: make it configurable via settings Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index c957138044eff1b73aa2182707c2e3acd7a2a73d..a445e3d16cf74490999f3352a9fdd28d05d4b27e 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -3217,7 +3217,7 @@ bool Element::isSpellCheckingEnabled() const

}

- return true;

+ return document().page()->settings().spellCheckEnabledByDefault();

Rick Byers 2016/09/15 20:28:09 I believe there are cases where page() could be nu

timvolodine 2016/09/22 17:52:57 Done.

}

#if DCHECK_IS_ON()