Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2316133002: Fix a bug where read-only volumes were recognized as read-write. (Closed)

Created:
4 years, 3 months ago by yamaguchi
Modified:
4 years, 3 months ago
Reviewers:
satorux1, fukino
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix a bug where read-only volumes were recognized as read-write. This problem happened because the read-only attribute of the disk volume was unconditionally overwritten by the values in |access_modes_|. The patch fixes this problem by applying the values in |access_modes_| only when it's needed. The bug was introduced in crrev.com/2230713003 . BUG=644077 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2311863002 Cr-Commit-Position: refs/heads/master@{#416575} (cherry picked from commit 21448d5b5c6aaa880981393d0c55ef865b754596)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M chromeos/disks/disk_mount_manager.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/disks/disk_mount_manager_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yamaguchi
I would like to cherrypick this patch to fix the known issue with current M54 ...
4 years, 3 months ago (2016-09-07 13:34:06 UTC) #2
satorux1
lgtm, but do you need a code review for merging?
4 years, 3 months ago (2016-09-08 05:30:35 UTC) #4
fukino
On 2016/09/08 05:30:35, satorux1 wrote: > lgtm, but do you need a code review for ...
4 years, 3 months ago (2016-09-08 05:31:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316133002/1
4 years, 3 months ago (2016-09-08 05:32:31 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-08 05:32:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316133002/1
4 years, 3 months ago (2016-09-08 05:35:55 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 05:47:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698