Fix a bug where read-only volumes were recognized as read-write.

Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077
Committed: https://crrev.com/21448d5b5c6aaa880981393d0c55ef865b754596
Cr-Commit-Position: refs/heads/master@{#416575}

[yamaguchi, 2016-09-05 12:14:14]

yamaguchi@chromium.org changed reviewers:
+ satorux@chromium.org

[yamaguchi, 2016-09-05 13:56:11]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 13:56:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 14:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 14:29:38]

Dry run: This issue passed the CQ dry run.

[satorux1, 2016-09-06 01:53:16]

LGTM, but could you revise the description? This change is a bug fix, but it's
not clear from the description. Something like:


Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/xxx.

[yamaguchi, 2016-09-06 01:58:23]

Description was changed from

==========
Recognize a disk as read-only when the block device is read-only.

BUG=644077
==========

to

==========
Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077
==========

[yamaguchi, 2016-09-06 02:00:07]

On 2016/09/06 01:53:16, satorux1 wrote:
> LGTM, but could you revise the description? This change is a bug fix, but it's
> not clear from the description. Something like:
> 
> 
> Fix a bug where read-only volumes were recognized as read-write.
> 
> This problem happened because the read-only attribute of the disk volume was
> unconditionally overwritten by the values in |access_modes_|. The patch fixes
> this problem by applying the values in |access_modes_| only when it's needed.
> 
> The bug was introduced in crrev.com/xxx.

Done. Thanks.

[yamaguchi, 2016-09-06 02:00:13]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2016-09-06 02:00:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 02:05:11]

Description was changed from

==========
Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077
==========

to

==========
Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077
==========

[commit-bot: I haz the power, 2016-09-06 02:05:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-06 02:07:21]

Description was changed from

==========
Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077
==========

to

==========
Fix a bug where read-only volumes were recognized as read-write.

This problem happened because the read-only attribute of the disk volume was
unconditionally overwritten by the values in |access_modes_|. The patch fixes
this problem by applying the values in |access_modes_| only when it's needed.

The bug was introduced in crrev.com/2230713003 .

BUG=644077

Committed: https://crrev.com/21448d5b5c6aaa880981393d0c55ef865b754596
Cr-Commit-Position: refs/heads/master@{#416575}
==========

[commit-bot: I haz the power, 2016-09-06 02:07:22]

Patchset 2 (id:??) landed as
https://crrev.com/21448d5b5c6aaa880981393d0c55ef865b754596
Cr-Commit-Position: refs/heads/master@{#416575}