Source/web/ChromeClientImpl.cpp - Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix assert Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 17d9d3268ed1f550e52259af7182df177b6d1ca5..0a42eb721f32be3bf34afae4e99897917cfe2a0d 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -745,6 +745,10 @@ WebCore::CompositingTriggerFlags ChromeClientImpl::allowedCompositingTriggers()

flags |= WebCore::LegacyOverflowScrollTrigger;

if (settings.compositorDrivenAcceleratedScrollingEnabled())

flags |= WebCore::OverflowScrollTrigger;

+ // FIXME: acceleratedCompositingForFixedPositionEnabled should be renamed acceleratedCompositingForViewportConstrainedPositionEnabled().

+ // Or the sticky and fixed position elements should be behind different flags.

+ if (settings.acceleratedCompositingForFixedPositionEnabled())

+ flags |= WebCore::ViewportConstrainedPositionedTrigger;

return flags;

}