Source/core/rendering/compositing/CompositingReasonFinder.h - Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.h

Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix assert Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/compositing/CompositingReasonFinder.h

diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.h b/Source/core/rendering/compositing/CompositingReasonFinder.h

index c13987cdf5037b7c52c6eb032855bfa4c3e5692c..37afa5ba23d321c10502e3b1009a88e23a1cd91c 100644

--- a/Source/core/rendering/compositing/CompositingReasonFinder.h

+++ b/Source/core/rendering/compositing/CompositingReasonFinder.h

@@ -33,6 +33,8 @@ public:

bool requiresCompositingForScrollableFrame() const;

bool requiresCompositingForPosition(RenderObject*, const RenderLayer*, RenderLayer::ViewportConstrainedNotCompositedReason*, bool* needToRecomputeCompositingRequirements) const;

+ bool requiresCompositingForPositionSticky(RenderObject*, const RenderLayer*) const;

+ bool requiresCompositingForPositionFixed(RenderObject*, const RenderLayer*, RenderLayer::ViewportConstrainedNotCompositedReason*, bool* needToRecomputeCompositingRequirements) const;

abarth-chromium 2014/04/12 01:17:56 Can these be private?

static bool isViewportConstrainedFixedOrStickyLayer(const RenderLayer*);

« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/rendering/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »