Source/core/rendering/compositing/CompositingReasonFinder.h - Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition

Side by Side Diff: Source/core/rendering/compositing/CompositingReasonFinder.h

Issue 231613002: Cleanup CompositingReasonFinder::requiresCompositingForPosition (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix assert Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/rendering/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CompositingReasonFinder_h	5 #ifndef CompositingReasonFinder_h

6 #define CompositingReasonFinder_h	6 #define CompositingReasonFinder_h

7	7

8 #include "core/rendering/RenderLayer.h"	8 #include "core/rendering/RenderLayer.h"

9 #include "core/rendering/compositing/CompositingTriggers.h"	9 #include "core/rendering/compositing/CompositingTriggers.h"

10 #include "platform/graphics/CompositingReasons.h"	10 #include "platform/graphics/CompositingReasons.h"

(...skipping 15 matching lines...) Expand all Loading...
26 void updateTriggers();	26 void updateTriggers();

27 bool hasTriggers() const { return m_compositingTriggers; }	27 bool hasTriggers() const { return m_compositingTriggers; }

28	28

29 bool has3DTransformTrigger() const;	29 bool has3DTransformTrigger() const;

30 bool hasAnimationTrigger() const;	30 bool hasAnimationTrigger() const;

31 bool hasOverflowScrollTrigger() const;	31 bool hasOverflowScrollTrigger() const;

32 bool hasLegacyOverflowScrollTrigger() const;	32 bool hasLegacyOverflowScrollTrigger() const;

33	33

34 bool requiresCompositingForScrollableFrame() const;	34 bool requiresCompositingForScrollableFrame() const;

35 bool requiresCompositingForPosition(RenderObject, const RenderLayer, Rende rLayer::ViewportConstrainedNotCompositedReason, bool needToRecomputeCompositin gRequirements) const;	35 bool requiresCompositingForPosition(RenderObject, const RenderLayer, Rende rLayer::ViewportConstrainedNotCompositedReason, bool needToRecomputeCompositin gRequirements) const;

	36 bool requiresCompositingForPositionSticky(RenderObject, const RenderLayer) const;

	37 bool requiresCompositingForPositionFixed(RenderObject, const RenderLayer, RenderLayer::ViewportConstrainedNotCompositedReason, bool needToRecomputeCompo sitingRequirements) const;
	abarth-chromium 2014/04/12 01:17:56 Can these be private? Can these be private?
36	38

37 static bool isViewportConstrainedFixedOrStickyLayer(const RenderLayer*);	39 static bool isViewportConstrainedFixedOrStickyLayer(const RenderLayer*);

38	40

39 private:	41 private:

40 bool isMainFrame() const;	42 bool isMainFrame() const;

41	43

42 CompositingReasons nonStyleDeterminedDirectReasons(const RenderLayer, bool needToRecomputeCompositingRequirements) const;	44 CompositingReasons nonStyleDeterminedDirectReasons(const RenderLayer, bool needToRecomputeCompositingRequirements) const;

43	45

44 bool requiresCompositingForAnimation(RenderObject*) const;	46 bool requiresCompositingForAnimation(RenderObject*) const;

45 bool requiresCompositingForTransform(RenderObject*) const;	47 bool requiresCompositingForTransform(RenderObject*) const;

46 bool requiresCompositingForBackfaceVisibilityHidden(RenderObject*) const;	48 bool requiresCompositingForBackfaceVisibilityHidden(RenderObject*) const;

47 bool requiresCompositingForFilters(RenderObject*) const;	49 bool requiresCompositingForFilters(RenderObject*) const;

48 bool requiresCompositingForOverflowScrollingParent(const RenderLayer*) const ;	50 bool requiresCompositingForOverflowScrollingParent(const RenderLayer*) const ;

49 bool requiresCompositingForOutOfFlowClipping(const RenderLayer*) const;	51 bool requiresCompositingForOutOfFlowClipping(const RenderLayer*) const;

50 bool requiresCompositingForOverflowScrolling(const RenderLayer*) const;	52 bool requiresCompositingForOverflowScrolling(const RenderLayer*) const;

51 bool requiresCompositingForWillChange(const RenderObject*) const;	53 bool requiresCompositingForWillChange(const RenderObject*) const;

52	54

53 RenderView& m_renderView;	55 RenderView& m_renderView;

54 CompositingTriggerFlags m_compositingTriggers;	56 CompositingTriggerFlags m_compositingTriggers;

55 };	57 };

56	58

57 } // namespace WebCore	59 } // namespace WebCore

58	60

59 #endif // CompositingReasonFinder_h	61 #endif // CompositingReasonFinder_h

OLD	NEW