Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2316093003: ignore hints in DDC's build (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/dev_compiler/tool/analyze.sh View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
in particular, something marked deprecated in analyzer shouldn't cause the bot to instantly go red ...
4 years, 3 months ago (2016-09-08 00:03:32 UTC) #2
vsm
lgtm
4 years, 3 months ago (2016-09-08 00:46:13 UTC) #3
Jennifer Messerly
4 years, 3 months ago (2016-09-08 15:59:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b797899b35bf34457b1a5d95e39a2d3aa0b6b9f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698