| OLD | NEW |
|---|
| 1 #!/bin/bash | 1 #!/bin/bash |
| 2 set -e | 2 set -e |
| 3 | 3 |
| 4 # Switch to the root directory of dev_compiler | 4 # Switch to the root directory of dev_compiler |
| 5 cd $( dirname "${BASH_SOURCE[0]}" )/.. | 5 cd $( dirname "${BASH_SOURCE[0]}" )/.. |
| 6 | 6 |
| 7 function fail { | 7 function fail { |
| 8 echo -e "[31mAnalyzer found problems[0m" | 8 echo -e "[31mAnalyzer found problems[0m" |
| 9 return 1 | 9 return 1 |
| 10 } | 10 } |
| 11 | 11 |
| 12 # Run analyzer on bin/dartdevc.dart, as it includes most of the code we care | 12 # Run analyzer on bin/dartdevc.dart, as it includes most of the code we care |
| 13 # about via transitive dependencies. This seems to be the only fast way to avoid | 13 # about via transitive dependencies. This seems to be the only fast way to avoid |
| 14 # repeated analysis of the same code. | 14 # repeated analysis of the same code. |
| 15 # TODO(jmesserly): ideally we could do test/all_tests.dart, but | 15 # TODO(jmesserly): ideally we could do test/all_tests.dart, but |
| 16 # dart_runtime_test.dart creates invalid generic type instantiation AA. | 16 # dart_runtime_test.dart creates invalid generic type instantiation AA. |
| 17 echo "Running dartanalyzer to check for errors/warnings/hints..." | 17 echo "Running dartanalyzer to check for errors/warnings..." |
| 18 dartanalyzer --strong --fatal-warnings --package-warnings \ | 18 dartanalyzer --strong --package-warnings \ |
| 19 bin/dartdevc.dart web/main.dart \ | 19 bin/dartdevc.dart web/main.dart \ |
| 20 | grep -v "\[info\] TODO" | (! grep $PWD) || fail | 20 | grep -v "\[info\]" | grep -v "\[hint\]" | (! grep $PWD) || fail |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2316093003:
ignore hints in DDC's build (Closed)
