DevTools: Update devtools recipe with tryserver logic

DevTools: Update devtools recipe with tryserver logic

I realized my current recipe isn't working as intended because 
get_files_affected_by_patch() is only intended for tryservers.

For try jobs: this will skip checks if there's no devtools file in the patch.
For other jobs (e.g. main / FYI): this will always run the devtools checks.

I will open another CL to add the tryserver experiment.

BUG=642046
Committed: https://chromium.googlesource.com/chromium/tools/build/+/f9c6f0966908f1d125ea8f519cf31b8a84aff886

[chenwilliam, 2016-09-07 01:28:06]

Description was changed from

==========
DevTools: Update recipe and configure tryjob experiment

BUG=642046
==========

to

==========
DevTools: Update devtools recipe with tryserver logic

I realized my current recipe isn't working as intended because 
get_files_affected_by_patch() is only intended for tryservers.

For try jobs: this will skip checks if there's no devtools file in the patch.
For other jobs (e.g. main / FYI): this will always run the devtools checks.

I will open another CL to add the tryserver experiment.

BUG=642046
==========

[chenwilliam, 2016-09-07 01:34:18]

chenwilliam@chromium.org changed reviewers:
+ hinoka@chromium.org, iannucci@chromium.org

[chenwilliam, 2016-09-07 01:34:19]

PTAL. Thanks.

[iannucci, 2016-09-07 01:46:12]

lgtm

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
File scripts/slave/recipes/devtools.py (right):

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:36: return True
# gloabally
AFFECTED_PATHS = (
  'third_party/WebKit/Source/devtools',
)

# in this function, replacing these last 6 lines
return any(fname.startswith(AFFECTED_PATHS) 
           for fname in api.chromium_checkout.get_files_affected_by_patch())

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:49: return
api.path['checkout'].join(*joined_path)
this looks duplicated, but maybe it's rietveld?

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:76: rietveld=True,
this should be rietveld='https://rietveld.example.com' or similar; this is the
url of the rietveld server to use.

[chenwilliam, 2016-09-07 17:35:03]

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
File scripts/slave/recipes/devtools.py (right):

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:36: return True
On 2016/09/07 01:46:11, iannucci wrote:
> # gloabally
> AFFECTED_PATHS = (
>   'third_party/WebKit/Source/devtools',
> )
> 
> # in this function, replacing these last 6 lines
> return any(fname.startswith(AFFECTED_PATHS) 
>            for fname in api.chromium_checkout.get_files_affected_by_patch())

Done.

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:49: return
api.path['checkout'].join(*joined_path)
On 2016/09/07 01:46:11, iannucci wrote:
> this looks duplicated, but maybe it's rietveld?

I think this is just the rietveld diff.

https://codereview.chromium.org/2315983002/diff/1/scripts/slave/recipes/devto...
scripts/slave/recipes/devtools.py:76: rietveld=True,
On 2016/09/07 01:46:11, iannucci wrote:
> this should be rietveld='https://rietveld.example.com' or similar; this is the
> url of the rietveld server to use.

Done.

[chenwilliam, 2016-09-07 17:35:08]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2016-09-07 17:35:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2315983002/#ps20001
(title: "Address CL feedback")

[commit-bot: I haz the power, 2016-09-07 17:35:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:39:35]

Description was changed from

==========
DevTools: Update devtools recipe with tryserver logic

I realized my current recipe isn't working as intended because 
get_files_affected_by_patch() is only intended for tryservers.

For try jobs: this will skip checks if there's no devtools file in the patch.
For other jobs (e.g. main / FYI): this will always run the devtools checks.

I will open another CL to add the tryserver experiment.

BUG=642046
==========

to

==========
DevTools: Update devtools recipe with tryserver logic

I realized my current recipe isn't working as intended because 
get_files_affected_by_patch() is only intended for tryservers.

For try jobs: this will skip checks if there's no devtools file in the patch.
For other jobs (e.g. main / FYI): this will always run the devtools checks.

I will open another CL to add the tryserver experiment.

BUG=642046

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f9c6f0966908f1d125ea...
==========

[commit-bot: I haz the power, 2016-09-07 17:39:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/f9c6f0966908f1d125ea...