Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: scripts/slave/recipes/devtools.expected/devtools_fyi_tryserver_with_devtools.json

Issue 2315983002: DevTools: Update devtools recipe with tryserver logic (Closed)
Patch Set: Address CL feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/devtools.expected/devtools_fyi_tryserver_with_devtools.json
diff --git a/scripts/slave/recipes/devtools.expected/devtools_fyi_with_devtools_file.json b/scripts/slave/recipes/devtools.expected/devtools_fyi_tryserver_with_devtools.json
similarity index 93%
rename from scripts/slave/recipes/devtools.expected/devtools_fyi_with_devtools_file.json
rename to scripts/slave/recipes/devtools.expected/devtools_fyi_tryserver_with_devtools.json
index 458269375d25cb61037c43cb644c03a4211ccd3f..dd1ad42d9750919d4507605bebbe1dc961b7b3f6 100644
--- a/scripts/slave/recipes/devtools.expected/devtools_fyi_with_devtools_file.json
+++ b/scripts/slave/recipes/devtools.expected/devtools_fyi_tryserver_with_devtools.json
@@ -18,6 +18,12 @@
"{\"src\": \"got_revision\", \"src/buildtools\": \"got_buildtools_revision\", \"src/native_client\": \"got_nacl_revision\", \"src/third_party/angle\": \"got_angle_revision\", \"src/third_party/webrtc\": \"got_webrtc_revision\", \"src/tools/swarming_client\": \"got_swarming_client_revision\", \"src/v8\": \"got_v8_revision\"}",
"--git-cache-dir",
"[GIT_CACHE]",
+ "--issue",
+ "1",
+ "--patchset",
+ "2",
+ "--rietveld_server",
+ "https://rietveld.example.com",
"--output_json",
"/path/to/tmp/json",
"--revision",
@@ -123,7 +129,7 @@
"cmd": [
"python",
"-u",
- "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/scripts/buildbot/npm.py",
+ "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/scripts/buildbot/node.py",
"--version"
],
"name": "install node.js and npm"
@@ -145,8 +151,7 @@
"git",
"retry",
"fetch",
- "origin",
- "master"
+ "origin"
],
"cwd": "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/npm_modules",
"env": {
@@ -159,7 +164,7 @@
"git",
"checkout",
"-f",
- "FETCH_HEAD"
+ "8451e3a3fae09eaa18ddeed0c069a8e2f0e3541c"
],
"cwd": "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/npm_modules",
"name": "git checkout"
@@ -212,29 +217,13 @@
"cmd": [
"python",
"-u",
- "RECIPE_MODULE[recipe_engine::shutil]/resources/rmtree.py",
- "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/node_modules"
- ],
- "name": "rmtree [SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/node_modules"
- },
- {
- "cmd": [
- "python",
- "-u",
- "\nimport shutil\nimport sys\nshutil.copytree(sys.argv[1], sys.argv[2], symlinks=bool(sys.argv[3]))\n",
- "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/npm_modules/devtools/node_modules",
- "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/node_modules",
- "0"
- ],
- "name": "copy npm modules"
- },
- {
- "cmd": [
- "python",
- "-u",
- "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/scripts/buildbot/npm.py",
- "run",
- "lint"
+ "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/scripts/buildbot/node.py",
+ "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools/npm_modules/node_modules/.bin/eslint",
+ "-c",
+ "front_end/.eslintrc.js",
+ "--ignore-path",
+ "front_end/.eslintignore",
+ "front_end"
],
"cwd": "[SLAVE_BUILD]/src/third_party/WebKit/Source/devtools",
"name": "run eslint"

Powered by Google App Engine
This is Rietveld 408576698