Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2315653002: Do not start goma in ChromeOS gclient runhook if gomadir is given. (Closed)
Patch Set: added a comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 4148bab75d75e41fb2ae18dbe28f0712c2963cef..9ca75d44d8ec43df3b8fabd5fcc625cf63c239a6 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -476,6 +476,11 @@ class ChromiumApi(recipe_api.RecipeApi):
wrapper += ['--clear-sdk-cache']
if self.c.compile_py.goma_dir:
wrapper += ['--gomadir', self.c.compile_py.goma_dir]
+ # Since we are very sure api.chromium.compile starts compiler_proxy,
+ # and starting compiler_proxy here make it difficult for us to
+ # investigate the compiler_proxy start-up failure reason,
+ # let me stop starting compiler_proxy. (crbug.com/639432)
+ wrapper += ['--nostart-goma']
if self.c.gyp_env.GYP_DEFINES.get('fastbuild', 0) == 1:
wrapper += ['--fastbuild']
wrapper += ['--']
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698