Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2315653002: Do not start goma in ChromeOS gclient runhook if gomadir is given. (Closed)
Patch Set: added a comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from recipe_engine import recipe_api 7 from recipe_engine import recipe_api
8 from recipe_engine import util as recipe_util 8 from recipe_engine import util as recipe_util
9 9
10 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder): 10 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 self.m.depot_tools.cros_path, 'chrome-sdk', 469 self.m.depot_tools.cros_path, 'chrome-sdk',
470 '--board=%s' % (self.c.TARGET_CROS_BOARD,), 470 '--board=%s' % (self.c.TARGET_CROS_BOARD,),
471 '--nocolor',] 471 '--nocolor',]
472 wrapper += self.c.cros_sdk.args 472 wrapper += self.c.cros_sdk.args
473 if self.c.cros_sdk.external: 473 if self.c.cros_sdk.external:
474 wrapper += ['--use-external-config'] 474 wrapper += ['--use-external-config']
475 if clean: 475 if clean:
476 wrapper += ['--clear-sdk-cache'] 476 wrapper += ['--clear-sdk-cache']
477 if self.c.compile_py.goma_dir: 477 if self.c.compile_py.goma_dir:
478 wrapper += ['--gomadir', self.c.compile_py.goma_dir] 478 wrapper += ['--gomadir', self.c.compile_py.goma_dir]
479 # Since we are very sure api.chromium.compile starts compiler_proxy,
480 # and starting compiler_proxy here make it difficult for us to
481 # investigate the compiler_proxy start-up failure reason,
482 # let me stop starting compiler_proxy. (crbug.com/639432)
483 wrapper += ['--nostart-goma']
479 if self.c.gyp_env.GYP_DEFINES.get('fastbuild', 0) == 1: 484 if self.c.gyp_env.GYP_DEFINES.get('fastbuild', 0) == 1:
480 wrapper += ['--fastbuild'] 485 wrapper += ['--fastbuild']
481 wrapper += ['--'] 486 wrapper += ['--']
482 return wrapper 487 return wrapper
483 488
484 def ensure_goma(self, canary=False): 489 def ensure_goma(self, canary=False):
485 goma_dir = self.m.goma.ensure_goma(canary=canary) 490 goma_dir = self.m.goma.ensure_goma(canary=canary)
486 if goma_dir: 491 if goma_dir:
487 # TODO(phajdan.jr): goma_dir should always be non-empty. 492 # TODO(phajdan.jr): goma_dir should always be non-empty.
488 self.c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir 493 self.c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 })) 809 }))
805 810
806 def get_annotate_by_test_name(self, test_name): 811 def get_annotate_by_test_name(self, test_name):
807 return 'graphing' 812 return 'graphing'
808 813
809 def download_lto_plugin(self): 814 def download_lto_plugin(self):
810 return self.m.python( 815 return self.m.python(
811 name='download LTO plugin', 816 name='download LTO plugin',
812 script=self.m.path['checkout'].join( 817 script=self.m.path['checkout'].join(
813 'build', 'download_gold_plugin.py')) 818 'build', 'download_gold_plugin.py'))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698