Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2315453002: [arm] Improve generation of flag setting instructions. (Closed)

Created:
4 years, 3 months ago by georgia.kouveli
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Improve generation of flag setting instructions. Generate a flag-setting instruction for a binary operation when the result is tested for equality/inequality to zero. BUG= Committed: https://crrev.com/9da7ac6fdb39274f6bdf34aeb683874d5f9150c0 Cr-Commit-Position: refs/heads/master@{#39183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 5 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
georgia.kouveli
4 years, 3 months ago (2016-09-05 10:08:06 UTC) #2
epertoso
lgtm
4 years, 3 months ago (2016-09-05 15:08:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315453002/1
4 years, 3 months ago (2016-09-05 15:54:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 16:18:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 16:18:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da7ac6fdb39274f6bdf34aeb683874d5f9150c0
Cr-Commit-Position: refs/heads/master@{#39183}

Powered by Google App Engine
This is Rietveld 408576698